Commit Graph

2956 Commits

Author SHA1 Message Date
Wolfgang Witt
d6e39fb07c chore: unify runDB calls 2021-04-13 15:06:26 +02:00
Wolfgang Witt
89e7345b8c Apply 2 suggestion(s) to 2 file(s) 2021-04-13 15:06:26 +02:00
Wolfgang Witt
ca3d2713e6 Apply 1 suggestion(s) to 1 file(s) 2021-04-13 15:06:26 +02:00
Wolfgang Witt
544f5af78d chore: reset Handler.Course.Show to master state
remove two new lines leftover from previous edited state
2021-04-13 15:06:25 +02:00
Wolfgang Witt
0e7e042ef8 chore: only show favourite-toggle in sidenav + code cleanup 2021-04-13 15:06:25 +02:00
Wolfgang Witt
7a1dc57134 chore: try out different toggle-button locations 2021-04-13 15:06:24 +02:00
Wolfgang Witt
4ddbcc4217 chore: use css classes 2021-04-13 15:06:24 +02:00
Wolfgang Witt
f99d071601 chore: newline experiments 2021-04-13 15:06:24 +02:00
Wolfgang Witt
712dcfbf9d chore: adjust icon size 2021-04-13 15:06:24 +02:00
Wolfgang Witt
9da26e9ae1 chore: add BCLink-class to avoid outline 2021-04-13 15:06:24 +02:00
Wolfgang Witt
ad6671ed10 chore: use star icons 2021-04-13 15:06:23 +02:00
Wolfgang Witt
ebe676d39d refactor: hlint 2021-04-13 15:06:23 +02:00
Wolfgang Witt
7896c0bb16 chore: remove special case for participants 2021-04-13 15:06:23 +02:00
Wolfgang Witt
664c915065 chore: remove debug messages 2021-04-13 15:06:23 +02:00
Wolfgang Witt
56c26f3e51 chore: remove -Wwarn marker 2021-04-13 15:06:22 +02:00
Wolfgang Witt
91a7e11987 chore: implement favourite/blacklist toggle 2021-04-13 15:06:22 +02:00
Wolfgang Witt
3f48d5aa0c chore: only display favouriteToggle-Button when logged in 2021-04-13 15:06:22 +02:00
Wolfgang Witt
942c8bd59d chore: only write favourites to db when userMaxFavourites>0 2021-04-13 15:06:21 +02:00
Wolfgang Witt
0556b769cf refactor: don't interpret during lookup 2021-04-13 15:06:21 +02:00
Wolfgang Witt
0605e940c6 refactor: use the same function to lookup storedFavouriteReason 2021-04-13 15:06:21 +02:00
Wolfgang Witt
f0ddd680d1 chore: lookup current favourite reason in DB 2021-04-13 15:06:21 +02:00
Wolfgang Witt
e23a5a64cc chore: button only redirects to postCFavouriteR
actual swapping should happen there
still need to display the correct button
2021-04-13 15:06:21 +02:00
Wolfgang Witt
6b9c0849e4 chore: show some Icon calling postCFavouriteR 2021-04-13 15:06:20 +02:00
Gregor Kleen
9859c2e99c fix: prevent deleting sheet-referenced exam parts
Fixes #681
2021-04-13 14:51:31 +02:00
Gregor Kleen
5c709f1bbb fix: build 2021-04-13 12:18:12 +02:00
Winnie Ros
dbbc9c4a69 refactor(messages): continuing 2021-04-12 16:37:56 +02:00
Gregor Kleen
37cdc775b5 feat: partial support for lsf import
Work on #686
2021-04-12 11:54:13 +02:00
Gregor Kleen
3a92a1c1f2 chore: inline error message into help requests 2021-04-11 20:47:05 +02:00
Gregor Kleen
1717785a51 refactor: be more explicit about ARC strictness 2021-04-09 12:27:04 +02:00
Gregor Kleen
53a54a343d refactor: hlint 2021-04-08 19:33:46 +02:00
Gregor Kleen
939ab37588 feat: additional general purpose caching tier (memcachedLocal) 2021-04-08 18:36:06 +02:00
Winnie Ros
c2ea33066f refactor(messages): continuing utils-folder 2021-04-08 18:15:21 +02:00
Winnie Ros
2e57c81a75 refactor(messages): beginning utils-folder 2021-04-07 10:58:35 +02:00
Winnie Ros
8a9660c2d4 refactor(messages): user-folder 2021-04-06 12:57:48 +02:00
Winnie Ros
fadd3f1a79 refactor(messages): tutorial-folder 2021-04-06 12:37:55 +02:00
Winnie Ros
cbae982287 refactor(messages): submission-folder 2021-04-03 11:13:00 +02:00
Winnie Ros
cdaf1420e8 refactor(messages): admin-folder 2021-04-02 16:59:09 +02:00
Winnie Ros
f51679697f refactor(messages): sheet-folder 2021-04-02 15:53:10 +02:00
Gregor Kleen
d65bd6889b refactor: improve cryptoid caching 2021-03-30 20:02:16 +02:00
Gregor Kleen
6f291b2e68 feat(course-users-table): json export 2021-03-30 15:49:53 +02:00
Winnie Ros
607fb12fa4 refactor(messages): course-bugs fixed, exam/* finished 2021-03-30 13:22:13 +02:00
Gregor Kleen
af3ec98de5 fix(admin-tokens): avoid option none 2021-03-30 11:23:14 +02:00
Wolfgang Witt
5c56745042 chore: unify runDB calls 2021-03-29 16:03:40 +02:00
Wolfgang Witt
55319c8c50 fix: add missing do 2021-03-29 16:03:40 +02:00
Wolfgang Witt
67d6fd7d43 fix: correctly apply suggestion 2021-03-29 16:03:39 +02:00
Wolfgang Witt
fcc5930a3c Apply 1 suggestion(s) to 1 file(s) 2021-03-29 16:03:39 +02:00
Wolfgang Witt
16cbc78878 fix: correctly report NoUsers for ExamRoomRandom
preselection was ignored for the check so far
2021-03-29 16:03:38 +02:00
Wolfgang Witt
e00a2b074b chore: nudges for ExamRoomRandom have a bigger effect 2021-03-29 16:03:38 +02:00
Wolfgang Witt
f9b545952d chore: disable accept button for failing results 2021-03-29 16:03:38 +02:00
Wolfgang Witt
02589e4d00 fix: correct rebase-sourced error 2021-03-29 16:03:37 +02:00
Wolfgang Witt
ea32fdfa91 chore: convert buttons to icons 2021-03-29 16:03:37 +02:00
Wolfgang Witt
84a50646b0 chore: strikethrough names of ignored occurrences 2021-03-29 16:03:37 +02:00
Wolfgang Witt
25fa6ef0d7 refactor: hlint 2021-03-29 16:03:36 +02:00
Wolfgang Witt
a36f0deb09 chore: always show the correct ignore/reconsider button 2021-03-29 16:03:36 +02:00
Wolfgang Witt
b2d6eada17 refactor: calculate mimizeRooms before examAutoOccurrence 2021-03-29 16:03:36 +02:00
Wolfgang Witt
d5bd5042ad fix: correctly handle original minimizeRooms-flag 2021-03-29 16:03:36 +02:00
Wolfgang Witt
732df50530 fix: sort occurrences in the right order 2021-03-29 16:03:36 +02:00
Wolfgang Witt
30fb1462ab chore: make tests compile again 2021-03-29 16:03:36 +02:00
Wolfgang Witt
ce0f48b82a chore: don't redirect, but show a nullResult for Left 2021-03-29 16:03:35 +02:00
Wolfgang Witt
fabf56c164 fix: check space of occurrences after ignoring 2021-03-29 16:03:35 +02:00
Wolfgang Witt
11664dcd82 fix: buttons know about ALL actions from other buttons 2021-03-29 16:03:35 +02:00
Wolfgang Witt
13af035223 chore: correct button classes 2021-03-29 16:03:35 +02:00
Wolfgang Witt
65d0f24d71 chore: rename btn-constructors 2021-03-29 16:03:35 +02:00
Wolfgang Witt
362e2cf00d chore: also return sorted-state of occurrences 2021-03-29 16:03:34 +02:00
Wolfgang Witt
f6cbf99245 fix: oops 2021-03-29 16:03:34 +02:00
Wolfgang Witt
a35a481f33 chore: create (incomplete) ignore/reconsider buttons 2021-03-29 16:03:34 +02:00
Wolfgang Witt
25262aa7a5 chore: allow ignoring occurances based on a curated set 2021-03-29 16:03:34 +02:00
Wolfgang Witt
ddb68eeb98 chore: allow nudges between unrestricted rooms (random) 2021-03-29 16:03:33 +02:00
Wolfgang Witt
3ab8be2e0d chore: reimagine nudge usage
- scale appropriately for unrestricted sizes
- don't behave weirdly for very large rooms
2021-03-29 16:03:33 +02:00
Wolfgang Witt
ff5d27cdf3 refactor: don't store order of unrestrictedOccurrences 2021-03-29 16:03:33 +02:00
Wolfgang Witt
2be9d76af2 fix: use extraUsers instead of extraCapacity for unrestricted pseudo-capacity 2021-03-29 16:03:33 +02:00
Wolfgang Witt
b5ee9f2c05 refactor: make ExamOccurrenceCapacity a newtype
use pattern synonyms for convenience, so usage doesn't change
2021-03-29 16:03:33 +02:00
Wolfgang Witt
ae3e1b6266 Apply 1 suggestion(s) to 1 file(s) 2021-03-29 16:03:33 +02:00
Wolfgang Witt
74219c632d Apply 2 suggestion(s) to 2 file(s) 2021-03-29 16:03:32 +02:00
Wolfgang Witt
6e20c22f7d chore: introduce a real cost function for unrestricted rooms 2021-03-29 16:03:32 +02:00
Wolfgang Witt
b7d7252649 refactor: hlint 2021-03-29 16:03:32 +02:00
Wolfgang Witt
d34f674c3e chore: use ∞ to display unrestricted room size 2021-03-29 16:03:31 +02:00
Wolfgang Witt
03a0899f5f chore: chase error messages 2021-03-29 16:03:31 +02:00
Wolfgang Witt
1c24b8e5e2 chore: display unrestricted rooms as "-" 2021-03-29 16:03:31 +02:00
Wolfgang Witt
7e425754fc chore: inform examAutoOccurrence about unrestricted room sizes 2021-03-29 16:03:31 +02:00
Wolfgang Witt
d3661b69fd chore: create ExamRoomCapacity-type
_examRoomCapacityIso for convenience
2021-03-29 16:03:30 +02:00
Gregor Kleen
5dad0a79c7 chore: improve faq & results mail for allocations 2021-03-29 10:47:14 +02:00
Winnie Ros
ee7f32f5cc refactor(messages): course finished, templates-msgs added 2021-03-25 13:07:43 +01:00
Winnie Ros
580c62067a refactor(messages): course finished, templates missing 2021-03-25 11:13:16 +01:00
Gregor Kleen
0e50e6ebce perf: try to reduce db-conn-load of cached auth 2021-03-24 21:43:24 +01:00
Gregor Kleen
2f85cea1de perf: reduce db-conn-load of tokens 2021-03-24 17:35:40 +01:00
Gregor Kleen
ff8270042f fix: remove cached-db-runner
Observed "connection disconnected" from persistent on 25.5.0
CachedDBRunner seemed suspicious.
2021-03-23 21:53:33 +01:00
Gregor Kleen
3ff97aca77 refactor: hlint 2021-03-23 15:52:28 +01:00
Gregor Kleen
c23222aef6 perf: try to reduce db conn load of site-layout/nav 2021-03-23 15:18:37 +01:00
Gregor Kleen
da724654ed perf: try to reduce db connection load of auth 2021-03-23 11:07:05 +01:00
Gregor Kleen
1036926470 feat(course-participants): csv export first name/surname separately 2021-03-22 12:00:07 +01:00
Gregor Kleen
383d709620 refactor: give glossaryTerms better type 2021-03-19 16:58:10 +01:00
Gregor Kleen
8795edd1fa feat(submissions): also warn correctors about multiple submissions 2021-03-19 16:25:48 +01:00
Gregor Kleen
c19a00dcef feat(submissions): warn about multiple submissions for same user 2021-03-19 16:09:15 +01:00
Gregor Kleen
9d1f1c6910 fix(auth): wrong caching for external-exam-staff 2021-03-19 14:20:49 +01:00
Gregor Kleen
72191315b6 fix(submissions): improve submission process
Fixes #675
2021-03-19 14:13:32 +01:00
Gregor Kleen
78d0f2522d feat(exams): exam finish button 2021-03-19 00:05:56 +01:00
Gregor Kleen
a6390eccbd fix(submissions): take care when to display corrections
Also cleanup usage of Utils via hlint
2021-03-18 23:12:36 +01:00
Gregor Kleen
0c37cbff64 chore: generalize embedRenderMessage 2021-03-18 18:47:34 +01:00
Gregor Kleen
91a51664c3 feat(submissions): improve behaviour of sheet-type-exam-part
Fixes #676
2021-03-18 17:50:27 +01:00
Gregor Kleen
8bdaae0881 fix(csv-export): mime confusion 2021-03-17 21:38:18 +01:00
Gregor Kleen
5c513946c1 feat(csv-export): .xlsx 2021-03-17 21:15:00 +01:00
Gregor Kleen
f09f851e2b perf(admin-tokens): worse but faster selection of active users 2021-03-17 09:45:13 +01:00
Gregor Kleen
a314f64a70 fix: weight random token impersonation towards active users 2021-03-17 00:19:45 +01:00
Winnie Ros
51a90bbb5f refactor(messages): course/application/event 2021-03-16 16:40:57 +01:00
Gregor Kleen
600bbe5d7e feat: admins can efficiently generate many tokens for random users 2021-03-16 16:02:00 +01:00
Winnie Ros
8d9d3c613f refactor(messages): msgmenu only for navLabel, gender-neutral language navigation 2021-03-16 11:43:00 +01:00
Winnie Ros
c796bd5934 refactor(messages): navigation messages in new folder 2021-03-15 18:26:23 +01:00
Winnie Ros
7b10a9ae0f refactor(messages): breadcrumbs extracted and added 2021-03-15 17:23:30 +01:00
Wolfgang Witt
9b0adab023 chore: extende random distribution with nudges 2021-03-15 10:45:37 +00:00
Wolfgang Witt
9c928b0375 fix: make sure to report NoUsers, regardless of rule 2021-03-15 10:45:37 +00:00
Wolfgang Witt
e13049d958 chore(test): inform test about changed type signature 2021-03-15 10:45:37 +00:00
Wolfgang Witt
163715afc8 chore: hlint 2021-03-15 10:45:37 +00:00
Wolfgang Witt
a7671dbec6 chore: remove TODO marker 2021-03-15 10:45:37 +00:00
Wolfgang Witt
767090ded1 chore: check for no users first 2021-03-15 10:45:37 +00:00
Wolfgang Witt
5dc37a07c1 chore: improve error messages 2021-03-15 10:45:37 +00:00
Wolfgang Witt
0765f4b925 chore: chasing type-errors
messages are still temporary
2021-03-15 10:45:37 +00:00
Wolfgang Witt
e03326e1ac chore: examAutoOccurrence converted to Either 2021-03-15 10:45:37 +00:00
Wolfgang Witt
72d42baec5 chore: remove redundant seq 2021-03-15 10:45:37 +00:00
Wolfgang Witt
6dedb2b2a0 Apply 1 suggestion(s) to 1 file(s) 2021-03-15 10:45:37 +00:00
Wolfgang Witt
6ae1aeaeb0 Apply 5 suggestion(s) to 1 file(s) 2021-03-15 10:45:37 +00:00
Wolfgang Witt
85e3941538 chore: add my name to contributers + create changelog files 2021-03-15 10:45:37 +00:00
Wolfgang Witt
ad67c2e0e2 chore: remove trailing 'A' from surname-range-start
- still add it if the previous end was too short
- this way overall shorter descriptions are possible
- in rare cases (at maxTagLength) this  prevented a description to be created
2021-03-15 10:45:37 +00:00
Wolfgang Witt
c99d96ecb8 fix: handle rare cases where a mappingDescription with start>end would be produced 2021-03-15 10:45:37 +00:00
Wolfgang Witt
cd07a56a9f fix: correctly calculate maximum user name length 2021-03-15 10:45:37 +00:00
Wolfgang Witt
daceac95fc chore(test): relax requirements for justified nullResult
Instances with bigger user buckets than the smallest room might correctly fail
Thus, don't report an error for them.
2021-03-15 10:45:37 +00:00
Wolfgang Witt
7e1b75c2e1 fix: shown ranges "include" special mappings
previously, they stopped just before leading to clashes with the next range
e.g. Äm would cause Am as mapping end with the next starting at An
Now, the mapping end is AZ with the next starting at BA
2021-03-15 10:45:37 +00:00
Wolfgang Witt
4f4cd394db chore: add missing+remove redundant imports 2021-03-15 10:45:37 +00:00
Wolfgang Witt
b974942f07 chore: matriculation numbers limited same length again
- this time as suffixes
- also start range description with full used length
  otherwise suffix-description is confusing
2021-03-15 10:45:37 +00:00
Wolfgang Witt
f0a79dff65 chore: rewrite ExamRoomRandom mapping, so it actually respects room sizes 2021-03-15 10:45:37 +00:00
Wolfgang Witt
a559ac74cb chore: include non-ascii names in range-calculation 2021-03-15 10:45:37 +00:00
Wolfgang Witt
8e4cb0917d fix: make sure unfortunate combination doesn't only produce 0-9 ranges for matrikelnummer 2021-03-15 10:45:37 +00:00
Wolfgang Witt
fc35fd26c1 fix: mappingDescription doesn't overlap for the first n rooms/with small names/matrikelnummer 2021-03-15 10:45:37 +00:00
Wolfgang Witt
6ccc192426 chore: remove -Wwarn 2021-03-15 10:45:37 +00:00
Wolfgang Witt
5480e2d7b7 chore: names with non-ascii prefix get a ExamOccurrenceMappingSpecial 2021-03-15 10:45:37 +00:00
Wolfgang Witt
d60f93561f fix: make sure it compiles again + add 2-letter name 2021-03-15 10:45:37 +00:00
Wolfgang Witt
873d5a02ad fix: ensure termination for non-{'A'..'Z']-names 2021-03-15 10:45:37 +00:00
Wolfgang Witt
344bd420cd chore: don't use suffix of a prefix for mapping description 2021-03-15 10:45:37 +00:00
Wolfgang Witt
8f2b31acef chore: add padding to mappingRange if names are too short 2021-03-15 10:45:37 +00:00
Wolfgang Witt
5a3b2881c4 chore: rewrite resultAscList 2021-03-15 10:45:37 +00:00
Wolfgang Witt
f0f6706bcf chore: remove redundant MultiWayIf 2021-03-15 10:45:37 +00:00
Wolfgang Witt
479f4326b2 chore: filter out all empty/prefilled rooms
They might produce unnecessary null-results
2021-03-15 10:45:37 +00:00
Wolfgang Witt
317b95be31 fix: check if number of relevant user is >0 to prevent crash 2021-03-15 10:45:37 +00:00
Wolfgang Witt
44a52e034f chore: filter out pre-filled rooms 2021-03-15 10:45:37 +00:00
Wolfgang Witt
4fc05351fa fix: user with a pre-assigned room count towards the capacity limit 2021-03-15 10:45:37 +00:00
Wolfgang Witt
e487ceff58 fix: make sure line-break algorithm respects available lines 2021-03-15 10:45:37 +00:00
Wolfgang Witt
eaf245beaa fix: examAutoOccurence no longer user >100% of a room 2021-03-15 10:45:37 +00:00
Wolfgang Witt
7b0fd61f7f fix: spelling plugin had a suggestion; actually Hello World commit :p 2021-03-15 10:45:37 +00:00
Gregor Kleen
65814c005e fix(authorisation): inverted logic for empty 2021-03-13 17:53:44 +01:00
Gregor Kleen
e88b6d6bab fix: invalidate nav caches 2021-03-12 18:39:00 +01:00