Commit Graph

4699 Commits

Author SHA1 Message Date
Maximilian Tagher
1f05d2c72f
Explain how requireCheckJsonBody can prevent CSRF 2018-07-31 21:22:39 -07:00
Michael Snoyman
6f76b5ff91
Merge pull request #1544 from nmk/master
Do not lose selected value in `selectFieldHelper` when validation fails
2018-07-29 10:21:35 +03:00
Nickolay Kolev
073c9fabd4 Do not lose selected value in selectFieldHelper when validation fails 2018-07-26 20:44:26 +02:00
Steven Leiva
db1ff95520
Merge pull request #1540 from StevenXL/error-406
Fix Improper 406 Responses
2018-07-24 07:36:16 -05:00
Steven Leiva
266c436f18 selectRep chooses first rep if no matches found.
The `selectRep` documentation indicates that it choose the first
representation provided if no representation matches.

This was only partially correct, as `selectRep` required that no
representation matched **and** that the `Content-Type` header of the
response was empty.

This led to a problem because `defaultErrorhandler` relies on
`selectRep`, and when `selectRep` was unable to find a suitable
representation, it would "swallow" the original error that resulted in
`defaultErrorhandler` being called, and set a status 406 for all cases.
2018-07-19 21:32:02 -05:00
Michael Snoyman
1c51a93a45
Relax upper bounds 2018-07-11 08:20:20 +03:00
Michael Snoyman
04393855e5
Merge branch 'master' of github.com:yesodweb/yesod 2018-07-10 11:56:46 +03:00
Michael Snoyman
b7a3385a89
Merge pull request #1537 from kikaiteam/fix_forgot_pass_endpoint
AuthEmail: Fix forgot-password endpoint
2018-07-10 11:56:28 +03:00
Michael Snoyman
6fb09cfa5a
Merge pull request #1538 from kikaiteam/improve_auth_email_doc
AuthEmail: no-op, improve doc format
2018-07-10 11:55:46 +03:00
Michael Snoyman
074dc11678
Merge pull request #1539 from h-3-0/patch-1
Fix typo
2018-07-10 02:13:38 +03:00
Henri Jones
c221aa3aaa
Fix typo 2018-07-09 22:47:48 +01:00
hainq
72ad3082ce AuthEmail: no-op, improve doc format 2018-07-09 18:24:11 +07:00
hainq
d38affbe6d yesod-auth: update changelog & bump version 2018-07-09 17:52:07 +07:00
hainq
0c136f14eb AuthEmail: Fix forgot-password endpoint
This is a quick fix for PR#1524.
Currently, defining `emailPreviouslyRegisteredResponse` will prevent
`sendConfirmationEmail` from happening, even when `registerHelper` is
called from `postForgotPasswordR`.
2018-07-09 17:34:15 +07:00
Michael Snoyman
c1344a577f
Fix version bump 2018-07-09 13:12:40 +03:00
Michael Snoyman
71d951c09b
Correct the version bump (previous unreleased changes) 2018-07-09 13:10:55 +03:00
Michael Snoyman
e125795de3
Merge pull request #1536 from kikaiteam/support_more_email_register_flows
AuthEmail: Immediately register with a password
2018-07-09 12:55:08 +03:00
hainq
bd9d0f9922 yesod-auth: Bump version & Update Changelog 2018-07-09 14:06:53 +07:00
hainq
6a64debfa0 Redirect to afterVerificationWithPass when account was registered with a password 2018-07-09 14:02:10 +07:00
hainq
54b1d3d3ff AuthEmail: Immediately register with a password
Register endpoint: Support an optional "password" param that can be used
to set new accounts' password immediately.
2018-07-09 14:02:10 +07:00
Michael Snoyman
ea182bb464
Merge pull request #1534 from yesodweb/reduce-deps
Reduce deps
2018-07-04 09:34:31 +03:00
Michael Snoyman
182abd89bf
Drop some deps 2018-07-03 19:01:58 +03:00
Michael Snoyman
867e7c32dc
Clean up some CPP 2018-07-03 18:57:23 +03:00
Chris Allen
df5ad82a90
Merge pull request #1530 from pythonissam/expose-selectFieldHelper
Expose select field helper
2018-06-24 13:24:20 -05:00
Michael Snoyman
d134c20dab
Merge pull request #1524 from StevenXL/fix-email-registration
Fix email registration
2018-06-24 11:39:59 +03:00
Steven Leiva
8d58a56577 Make behavior of registerHelper configurable.
The behavior of `registerHelper` when an email that is already-verified
tries to register is now configurable via the
`emailPreviouslyRegisteredResponse` method of the `YesodAuthEmail`
typeclass.
2018-06-23 09:56:20 -05:00
pythonissam
01802e984b update the ChangeLog 2018-06-23 05:12:08 +00:00
Michael Snoyman
840f8faaaa
Merge pull request #1528 from ncaq/clean-appveyor
cleaned: appveyor: Easier to detect bugs
2018-06-20 06:22:38 +03:00
ncaq
6187c3cf09 cleaned: appveyor: Easier to detect bugs
* appveyor.yml conf file to simple from offcial reference
* Make the cache easier to use by commenting out
* fixed clone directory, from stack to yesod
* curl check https
* stack URL
* split build and test, So we can easy detect build or test error
* test job to single thread, So we can easy find bug of test
2018-06-20 10:49:28 +09:00
Michael Snoyman
a43e5a1cbb
Merge pull request #1526 from yesodweb/1523-fix-stalled-tests
1523 fix stalled tests
2018-06-19 11:24:12 +03:00
Michael Snoyman
d38d00f114 Skip RawResponse tests on Windows #1523
These tests stall on Windows starting with network-2.6.3.4. I haven't
yet figured out why exactly that's the case, or a minimum repro.
2018-06-19 10:37:20 +03:00
Michael Snoyman
12a2bb58e9 Add timeouts so stalling is more obvious 2018-06-19 09:52:20 +03:00
pythonissam
b5def68be2 Version bump 2018-06-17 08:46:52 +00:00
pythonissam
0b261f5073 Exposed 'selectFieldHelper' 2018-06-17 08:40:55 +00:00
Michael Snoyman
0437ace264
Merge pull request #1525 from StevenXL/bodyequals
bodyEquals prints actual body.
2018-06-14 09:17:51 -07:00
Steven Leiva
0a089c8cb0 bodyEquals prints actual body. 2018-06-14 09:00:48 -05:00
Michael Snoyman
cae2a9159a
Merge pull request #1520 from StevenXL/text-plain-error
defaultErrorHandler handles text/plain request.
2018-06-12 21:29:27 -07:00
Steven Leiva
a63bf16a68 defaultErrorHandler handles text/plain request. 2018-06-12 21:08:55 -05:00
Michael Snoyman
c88c2019ee
Merge pull request #1522 from ncaq/deleted-unneed-build-depends
deleted: unneed cabal build-depends by weeder
2018-06-12 07:53:12 -07:00
ncaq
708648798e deleted: unneed cabal build-depends by weeder
[weeder: Detect dead code](https://hackage.haskell.org/package/weeder)

deleted depends is

* mime-mail
* wai-eventsource

I sort build-depends, because duplicate depend some exist, to sort is detect to easy.
2018-06-09 13:15:21 +09:00
Michael Snoyman
c3a2a6afac
Merge pull request #1518 from psibi/update-issue-template
Update issue template slightly
2018-06-07 07:46:55 -06:00
Sibi Prabakaran
d15080ac4e
stack list-dependencies is deprecated 2018-06-06 20:39:56 +05:30
Michael Snoyman
74e43462cb
Merge pull request #1515 from yesodweb/multiple-stack-yamls
Multiple stack yamls
2018-06-04 06:40:03 -06:00
Michael Snoyman
908a758167 unliftio extra-deps 2018-06-03 14:54:21 -06:00
Michael Snoyman
a77b509bb6 Add warp to extra-deps 2018-06-03 14:35:50 -06:00
Michael Snoyman
3c2de1a763 Add persistent-sqlite extra-dep 2018-06-03 13:14:43 -06:00
Michael Snoyman
cdba6c1678 Fix CABALVER 2018-06-03 13:13:38 -06:00
Michael Snoyman
2cb60c8513 Multiple stack.yaml files 2018-06-03 11:42:44 -06:00
Michael Snoyman
d73f7b579f Travis update 2018-06-03 10:35:09 -06:00
Michael Snoyman
f21140ecf0
Merge pull request #1514 from pythonissam/isstring-textarea-instance
Make Textarea derive IsString
2018-06-03 06:29:09 -06:00