Stop emitting SubmissionFilesIgnored when nothing was ignored

2018-07-22 17:44:52 +02:00 · 2018-07-22 17:44:52 +02:00 · 969ada63d8
commit 969ada63d8
parent 8da542fb90
1 changed files with 3 additions and 2 deletions
--- a/src/Handler/Utils/Submission.hs
+++ b/src/Handler/Utils/Submission.hs
@ -235,8 +235,9 @@ extractRatingsMsg = do
  ignored' <- filterSubmission `fuseUpstream` Rating.extractRatings
  let ignored :: Set (Either CryptoFileNameSubmission FilePath)
      ignored = Right `Set.map` ignored'
-  mr <- (toHtml . ) <$> getMessageRender
-  addMessage "warning" =<< withUrlRenderer ($(ihamletFile "templates/messages/submissionFilesIgnored.hamlet") mr)
+  unless (null ignored) $ do
+    mr <- (toHtml . ) <$> getMessageRender
+    addMessage "warning" =<< withUrlRenderer ($(ihamletFile "templates/messages/submissionFilesIgnored.hamlet") mr)

 sinkSubmission :: UserId
               -> Either SheetId SubmissionId