From 969ada63d82e86e415ec936236756eec8670504e Mon Sep 17 00:00:00 2001 From: Gregor Kleen Date: Sun, 22 Jul 2018 17:44:52 +0200 Subject: [PATCH] Stop emitting SubmissionFilesIgnored when nothing was ignored --- src/Handler/Utils/Submission.hs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Handler/Utils/Submission.hs b/src/Handler/Utils/Submission.hs index 2fbfb5532..6b591928f 100644 --- a/src/Handler/Utils/Submission.hs +++ b/src/Handler/Utils/Submission.hs @@ -235,8 +235,9 @@ extractRatingsMsg = do ignored' <- filterSubmission `fuseUpstream` Rating.extractRatings let ignored :: Set (Either CryptoFileNameSubmission FilePath) ignored = Right `Set.map` ignored' - mr <- (toHtml . ) <$> getMessageRender - addMessage "warning" =<< withUrlRenderer ($(ihamletFile "templates/messages/submissionFilesIgnored.hamlet") mr) + unless (null ignored) $ do + mr <- (toHtml . ) <$> getMessageRender + addMessage "warning" =<< withUrlRenderer ($(ihamletFile "templates/messages/submissionFilesIgnored.hamlet") mr) sinkSubmission :: UserId -> Either SheetId SubmissionId