From 55f27b7382e17da0cff55f8f42c7855c88d630d7 Mon Sep 17 00:00:00 2001
From: David Mosbach <david.mosbach@campus.lmu.de>
Date: Thu, 10 Nov 2022 14:51:47 +0100
Subject: [PATCH 1/2] fix(diploma): renamed"diploma printed" state

---
 diploma.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/diploma.yaml b/diploma.yaml
index 03983bd..9932551 100644
--- a/diploma.yaml
+++ b/diploma.yaml
@@ -919,10 +919,10 @@ nodes:
   "zeugnis gedruckt, informatik": &zeugnis-gedruckt-informatik-node
     viewers:
       display-label: 
-        fallback: "Zeugnis gedruckt"
+        fallback: "Zeugnis gedruckt, Abholung noch nicht möglich"
         fallback-lang: de-de-formal
         translations:
-          en-eu: "Diploma Printed"   
+          en-eu: "Diploma Printed, Collection not Possible yet"
       viewers: *view-alle
     payload-view: *payload-view
     final: false

From c6685e7eba8394e251fdd3b5782488e170a946c2 Mon Sep 17 00:00:00 2001
From: David Mosbach <david.mosbach@campus.lmu.de>
Date: Sat, 12 Nov 2022 14:32:33 +0100
Subject: [PATCH 2/2] fix(diploma): internal states hidden from students

---
 diploma.yaml | 39 ++++++++++++++-------------------------
 1 file changed, 14 insertions(+), 25 deletions(-)

diff --git a/diploma.yaml b/diploma.yaml
index 9932551..0c8350d 100644
--- a/diploma.yaml
+++ b/diploma.yaml
@@ -228,6 +228,7 @@ nodes:
           translations:
             en-eu: "Modify application"
         source: "erstellung moeglich"
+        viewers: *view-internal
         actors: 
           - *PAmt
         view-actor: *view-minimal
@@ -295,6 +296,7 @@ nodes:
           translations:
             en-eu: "Create Closing Report for Student Office"
         source: "erstellung moeglich"
+        viewers: *view-internal
         actors: 
           - *PAmt
         view-actor: 
@@ -661,6 +663,7 @@ nodes:
         source: "antrag angenommen, informatik"
       "kommunikation anpassen, internal, antrag angenommen, informatik": 
         <<: *kommunikation-intern-edge
+        viewers: *view-internal
         source: "antrag angenommen, informatik"
       "vorlaeufiges zeugnis bereitstellen, antrag angenommen, informatik": 
         <<: *vorlaeufiges-zeugnis-edge
@@ -707,6 +710,7 @@ nodes:
         source: "antrag angenommen, medieninformatik"
       "kommunikation anpassen, internal, antrag angenommen, medieninformatik": 
         <<: *kommunikation-intern-edge
+        viewers: *view-internal
         source: "antrag angenommen, medieninformatik"
       "vorlaeufiges zeugnis bereitstellen, antrag angenommen, medieninformatik": 
         <<: *vorlaeufiges-zeugnis-edge
@@ -743,7 +747,7 @@ nodes:
         fallback-lang: de-de-formal
         translations:
           en-eu: "Certificates Created"   
-      viewers: *view-alle
+      viewers: *view-internal
 
     payload-view: *payload-view
 
@@ -780,6 +784,7 @@ nodes:
           translations:
             en-eu: "Report Creation of Certificates (Informatics)"
         source: "erstellung moeglich"
+        viewers: *view-internal
         view-actor: *view-alle
         actors:
           - *PAmt
@@ -923,7 +928,7 @@ nodes:
         fallback-lang: de-de-formal
         translations:
           en-eu: "Diploma Printed, Collection not Possible yet"
-      viewers: *view-alle
+      viewers: *view-internal
     payload-view: *payload-view
     final: false
     messages:
@@ -949,6 +954,7 @@ nodes:
           translations:
             en-eu: "Confirm Printout of Diploma"
         source: "zeugnisdateien erstellt, informatik"
+        viewers: *view-internal
         view-actor: *view-alle
         actors:
           - *Dek
@@ -983,7 +989,7 @@ nodes:
         fallback-lang: de-de-formal
         translations:
           en-eu: "Diploma Available for Signing"   
-      viewers: *view-alle
+      viewers: *view-internal
     payload-view: *payload-view
     final: false
     messages:
@@ -1009,6 +1015,7 @@ nodes:
           translations:
             en-eu: "Forward Diploma for Signing"
         source: "zeugnis gedruckt, informatik"
+        viewers: *view-internal
         view-actor: *view-alle
         actors:
           - *PAvor-I
@@ -1048,7 +1055,7 @@ nodes:
         fallback-lang: de-de-formal
         translations:
           en-eu: "Diploma Signed"   
-      viewers: *view-alle
+      viewers: *view-internal
     payload-view: *payload-view
     final: false
     messages:
@@ -1102,6 +1109,7 @@ nodes:
           translations:
             en-eu: "Confirm Signature of Diploma"
         source: "zeugnis gedruckt, informatik"
+        viewers: *view-internal
         view-actor: *view-alle
         actors:
           - *PAvor-I
@@ -1151,26 +1159,7 @@ nodes:
           - *Sek-MI1
           - *Sek-MI2
           
-  # "zeugnis abholung, informatik":
-  #   viewers:
-  #     display-label: 
-  #       fallback: "Zeugnis zur Abholung bereit"
-  #       fallback-lang: de-de-formal
-  #       translations:
-  #         en-eu: ""   
-  #     viewers: *view-alle
-  #   payload-view: *payload-view
-  #   final: false
-  #   messages: []
-  #   edges: 
-  #     "kommunikation anpassen, student, ": 
-  #       <<: *kommunikation-student-all-edge
-  #       source: "zeugnis abholung, informatik"
-  #     "kommunikation anpassen, internal, ": 
-  #       <<: *kommunikation-intern-all-edge
-  #       source: "zeugnis abholung, informatik"
-
-
+  
   ### Zeugnis abgeschickt ###
   
   "zeugnis abgeschickt, informatik": &zeugnis-abgeschickt-informatik-node
@@ -1203,7 +1192,7 @@ nodes:
       "zeugnisversand bestaetigen, informatik": &versand-bestaetigen-edge
         mode: manual
         display-label:
-          fallback: "Zeugnisversand bestätigen"
+          fallback: "Abschicken des Zeugnisses bestätigen"
           fallback-lang: de-de-formal
           translations:
             en-eu: "Confirm Transmission of Diploma"