From fea89a933fcd74ade1526834d86790a2a43653ce Mon Sep 17 00:00:00 2001 From: nek0 Date: Wed, 30 Sep 2015 15:24:56 +0200 Subject: [PATCH] added Changelog and cleaned Yesod/Commen remnants --- yesod-newsfeed/ChangeLog.md | 23 +++++++++++++++++++++++ yesod-newsfeed/Yesod/AtomFeed.hs | 1 - yesod-newsfeed/Yesod/Common.hs | 9 --------- yesod-newsfeed/Yesod/RssFeed.hs | 1 - 4 files changed, 23 insertions(+), 11 deletions(-) delete mode 100644 yesod-newsfeed/Yesod/Common.hs diff --git a/yesod-newsfeed/ChangeLog.md b/yesod-newsfeed/ChangeLog.md index e69de29b..e2d022ec 100644 --- a/yesod-newsfeed/ChangeLog.md +++ b/yesod-newsfeed/ChangeLog.md @@ -0,0 +1,23 @@ +#Changelog + +##2015-09-30: + +###Yesod/FeedTypes.hs + +* added `feedLogo` field to `Feed` type as `Maybe (url, Text)`. Should this field result in `Nothing`, nothing will be added to the feed. + * `url`: Defines the URL to the logi image + * `Text`: Is the description of the logo image. Will only be used for RSS feeds +* added `feedEntryEnclosure` field to `FeedEntry` type as `Maybe (url, Int, Text)`. Should this field result in `Nothing`, no data will be added to the feed entry. + * `url`: Defines the URL to the enclosed data + * `Int`: Is the content size in bytes. RSS requires this. + * `Text`: Is the MIME-type of the enclosed file. RSS requires this + +###Yesod/AtomFeed.hs + +* modified `template` function to append an `url` tag at the end of the feed, when the provided `feedLogo` is not `Nothing`. This might look awkward, since it will be appended *after* the entries. +* modified `entryTemplate` to append an `` to the feed entry. + +###Yesod/RssFeed.hs + +* modified `template` function to append an `` tag with its three required components ``, `` and `<link>`. `<url>` and `<title>` will be filled from `feedLogo`, `<link>` will be `feedLinkHome`. +* modified `entryTemplate` function to append an `<enclosure type=mime length=length url=url>` to the feed entry diff --git a/yesod-newsfeed/Yesod/AtomFeed.hs b/yesod-newsfeed/Yesod/AtomFeed.hs index fa6b48ff..af6a9ae7 100644 --- a/yesod-newsfeed/Yesod/AtomFeed.hs +++ b/yesod-newsfeed/Yesod/AtomFeed.hs @@ -28,7 +28,6 @@ module Yesod.AtomFeed import Yesod.Core import Yesod.FeedTypes -import Yesod.Common import Text.Hamlet (hamlet) import qualified Data.ByteString.Char8 as S8 import Data.Text (Text) diff --git a/yesod-newsfeed/Yesod/Common.hs b/yesod-newsfeed/Yesod/Common.hs deleted file mode 100644 index 148fc7f3..00000000 --- a/yesod-newsfeed/Yesod/Common.hs +++ /dev/null @@ -1,9 +0,0 @@ -module Yesod.Common - ( removeItem - ) where - -removeItem :: Eq a => a -> [a] -> [a] -removeItem _ [] = [] -removeItem r (x:xs) - | r == x = removeItem r xs - | otherwise = x : removeItem r xs diff --git a/yesod-newsfeed/Yesod/RssFeed.hs b/yesod-newsfeed/Yesod/RssFeed.hs index 430f23db..7963276b 100644 --- a/yesod-newsfeed/Yesod/RssFeed.hs +++ b/yesod-newsfeed/Yesod/RssFeed.hs @@ -24,7 +24,6 @@ module Yesod.RssFeed import Yesod.Core import Yesod.FeedTypes -import Yesod.Common import Text.Hamlet (hamlet) import qualified Data.ByteString.Char8 as S8 import Data.Text (Text, pack)