From c04d6f9ac79e75ec94e5515cf28edb1c6b356a00 Mon Sep 17 00:00:00 2001 From: Sibi Prabakaran Date: Sun, 4 Mar 2018 13:20:21 +0530 Subject: [PATCH 1/2] Remove MINIMAL pragma for authHttpManager MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We now have a default implementation for it. See this for more information: https://github.com/yesodweb/yesod/issues/1489#issuecomment-370200663 Helps in preventing warnings like this: ``` serverside.hs:40:10: warning: [-Wmissing-methods] • No explicit implementation for ‘authHttpManager’ • In the instance declaration for ‘YesodAuth App’ | 40 | instance YesodAuth App where | ^^^^^^^^^^^^^ ``` --- yesod-auth/Yesod/Auth.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yesod-auth/Yesod/Auth.hs b/yesod-auth/Yesod/Auth.hs index e4cda58c..60169f6e 100644 --- a/yesod-auth/Yesod/Auth.hs +++ b/yesod-auth/Yesod/Auth.hs @@ -243,7 +243,7 @@ class (Yesod master, PathPiece (AuthId master), RenderMessage master FormMessage man <- authHttpManager withRunInIO $ \run -> withResponse req man $ run . inner - {-# MINIMAL loginDest, logoutDest, (authenticate | getAuthId), authPlugins, authHttpManager #-} + {-# MINIMAL loginDest, logoutDest, (authenticate | getAuthId), authPlugins #-} {-# DEPRECATED getAuthId "Define 'authenticate' instead; 'getAuthId' will be removed in the next major version" #-} From ff043db45b2eac778be0afc2ce49cfe93244d581 Mon Sep 17 00:00:00 2001 From: Sibi Prabakaran Date: Sun, 4 Mar 2018 13:39:31 +0530 Subject: [PATCH 2/2] Update changelog --- yesod-auth/ChangeLog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/yesod-auth/ChangeLog.md b/yesod-auth/ChangeLog.md index 216990ab..64a70937 100644 --- a/yesod-auth/ChangeLog.md +++ b/yesod-auth/ChangeLog.md @@ -1,3 +1,7 @@ +## 1.6.2 + +* Remove MINIMAL praggma for authHttpManager [#1489](https://github.com/yesodweb/yesod/issues/1489) + ## 1.6.1 * Relax a number of type signatures [#1488](https://github.com/yesodweb/yesod/issues/1488)