haskell/yesod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove sometimes failing test

Browse Source 
This test sometimes fails on nix builds.
I'm not sure why, but it should be superflous with
"thread killed = 500" test anyway.

They test both for async exceptions.
Just a different one.
This commit is contained in:
Jappie Klooster 2022-03-25 07:30:33 -04:00
parent 3d65a3bf16
commit 73f20b6285
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
yesod-core/test/YesodCoreTest/ErrorHandling.hs
View File

@ -51,7 +51,6 @@ mkYesod "App" [parseRoutes|
/args-not-valid ArgsNotValidR POST /args-not-valid ArgsNotValidR POST
/only-plain-text OnlyPlainTextR GET /only-plain-text OnlyPlainTextR GET
/allocation-limit AlocationLimitR GET
/thread-killed ThreadKilledR GET /thread-killed ThreadKilledR GET
/async-session AsyncSessionR GET /async-session AsyncSessionR GET
|] |]
@ -120,17 +119,6 @@ goodBuilderContent = Data.Monoid.mconcat $ replicate 100 $ "This is a test\n"
getGoodBuilderR :: Handler TypedContent getGoodBuilderR :: Handler TypedContent
getGoodBuilderR = return $ TypedContent "text/plain" $ toContent goodBuilderContent getGoodBuilderR = return $ TypedContent "text/plain" $ toContent goodBuilderContent
getAlocationLimitR :: Handler Html
getAlocationLimitR =
(do
liftIO $ do
Mem.setAllocationCounter 1 -- very low limit
Mem.enableAllocationLimit
defaultLayout $ [whamlet|
<p> this will trigger https://hackage.haskell.org/package/base-4.16.0.0/docs/Control-Exception.html#t:AllocationLimitExceeded
which we need to catch
|]) `finally` liftIO Mem.disableAllocationLimit
-- this handler kills it's own thread -- this handler kills it's own thread
getThreadKilledR :: Handler Html getThreadKilledR :: Handler Html
getThreadKilledR = do getThreadKilledR = do
@ -191,7 +179,6 @@ errorHandlingTest = describe "Test.ErrorHandling" $ do
it "accept image, non-existent path -> 404" caseImageNotFound it "accept image, non-existent path -> 404" caseImageNotFound
it "accept video, bad method -> 405" caseVideoBadMethod it "accept video, bad method -> 405" caseVideoBadMethod
it "thread killed = 500" caseThreadKilled500 it "thread killed = 500" caseThreadKilled500
it "allocation limit = 500" caseAllocationLimit500
it "async session exception = 500" asyncSessionKilled500 it "async session exception = 500" asyncSessionKilled500
runner :: Session a -> IO a runner :: Session a -> IO a
@ -331,12 +318,6 @@ caseVideoBadMethod = runner $ do
} }
assertStatus 405 res assertStatus 405 res
caseAllocationLimit500 :: IO ()
caseAllocationLimit500 = runner $ do
res <- request defaultRequest { pathInfo = ["allocation-limit"] }
assertStatus 500 res
assertBodyContains "Internal Server Error" res
caseThreadKilled500 :: IO () caseThreadKilled500 :: IO ()
caseThreadKilled500 = runner $ do caseThreadKilled500 = runner $ do
res <- request defaultRequest { pathInfo = ["thread-killed"] } res <- request defaultRequest { pathInfo = ["thread-killed"] }