haskell/yesod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1544 from nmk/master

Browse Source 
Do not lose selected value in `selectFieldHelper` when validation fails
This commit is contained in:
Michael Snoyman 2018-07-29 10:21:35 +03:00 committed by GitHub
commit 6f76b5ff91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
yesod-form/ChangeLog.md
View File

@ -1,5 +1,10 @@
# ChangeLog for yesod-form # ChangeLog for yesod-form
## Unreleased
* make sure a select field does not lose the selected value even if a validation on the
field fails
## 1.6.2 ## 1.6.2
* Move `addClass` from private/undocumented in `Yesod.Form.Bootstrap3` to `Yesod.Form.Functions` [#1510](https://github.com/yesodweb/yesod/pull/1510) * Move `addClass` from private/undocumented in `Yesod.Form.Bootstrap3` to `Yesod.Form.Functions` [#1510](https://github.com/yesodweb/yesod/pull/1510)

2
yesod-form/Yesod/Form/Fields.hs
View File

@ -759,7 +759,7 @@ selectFieldHelper outside onOpt inside opts' = Field
, fieldEnctype = UrlEncoded , fieldEnctype = UrlEncoded
} }
where where
render _ (Left _) = "" render _ (Left x) = x
render opts (Right a) = maybe "" optionExternalValue $ listToMaybe $ filter ((== a) . optionInternalValue) opts render opts (Right a) = maybe "" optionExternalValue $ listToMaybe $ filter ((== a) . optionInternalValue) opts
selectParser _ [] = Right Nothing selectParser _ [] = Right Nothing
selectParser opts (s:_) = case s of selectParser opts (s:_) = case s of