From f9540819d56b92b42d12b810655e6ca0d0117925 Mon Sep 17 00:00:00 2001 From: Luke Murphy Date: Sat, 9 Dec 2017 18:30:27 +0100 Subject: [PATCH] Add NBs to a pull request template. --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++++ MAINTAINERS.md | 11 ----------- 2 files changed, 5 insertions(+), 11 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..6a17bef8 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,5 @@ +Checklist: +- [ ] Meaningful commit message. +- [ ] Some time passed since Hackage upload. +- [ ] Tested with Stackage Nightly. +--- diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 52f316de..2178f727 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -63,17 +63,6 @@ $ cabal test $ cabal haddock ``` -**NB** Please use commit messages like "add foo-bar" or "add johndev's packages" -(`build-constraints.yaml` is the most frequently changed file in this git repo -so commit messages like "update build-constraints.yaml" are not helpful). - -**NB2** There can be a delay of up to an hour before package versions -newly uploaded to Hackage appear to our build server. If you just -uploaded a package to Hackage that you're trying to get included, we -recommend waiting an hour before opening the PR. You can verify this -by making sure the latest version is listed at -https://github.com/commercialhaskell/all-cabal-metadata/tree/master/packages/. - ## Github and Notifications Stackage uses Github notifications to reduce overhead of contacting individual