haskell/stackage
1
0
Fork 0
mirror of https://github.com/commercialhaskell/stackage.git synced 2026-02-03 18:10:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #6267 from commercialhaskell/pr-template-ci

Browse Source 
Add note on CI failures in PR template
This commit is contained in:
Dan Burton 2021-11-15 11:25:17 -05:00 committed by GitHub
commit 15c08da6e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,5 +1,5 @@
Checklist: Checklist:
- [ ] Meaningful commit message, eg `add my-cool-package` (please not mention `build-constraints.yml`) - [ ] Meaningful commit message, eg `add my-cool-package` (please don't mention `build-constraints.yml`)
- [ ] At least 30 minutes have passed since uploading to Hackage - [ ] At least 30 minutes have passed since uploading to Hackage
- [ ] On your own machine, you have successfully run the following command (find verify-package in the root of this repo): - [ ] On your own machine, you have successfully run the following command (find verify-package in the root of this repo):
@ -11,3 +11,12 @@ The script runs virtually the following commands in a clean directory:
cd $package-$version cd $package-$version
rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
stack build --resolver nightly --haddock --test --bench --no-run-benchmarks stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
### CI
Our CI tries to line up build-constraints.yaml with the current state
of Hackage. This means that failures that are unrelated to your PR may
cause the check to fail. If you think a failure is unrelated you can
simply ignore it and the Curators will let you know if there is
anything you need to do.