From d0eba4e31ec10fc4a302ddd6466825da2fd1d466 Mon Sep 17 00:00:00 2001
From: Bryan Richter <bryan@haskell.foundation>
Date: Tue, 30 Apr 2024 14:25:08 +0300
Subject: [PATCH] Add a warning when NoSnapshotFile

---
 src/Stackage/Database/Cron.hs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/Stackage/Database/Cron.hs b/src/Stackage/Database/Cron.hs
index d7b5f68..5284f23 100644
--- a/src/Stackage/Database/Cron.hs
+++ b/src/Stackage/Database/Cron.hs
@@ -530,8 +530,7 @@ decideOnSnapshotUpdate SnapshotFileInfo {sfiSnapName, sfiUpdatedOn, sfiSnapshotF
         run (getBy (UniqueSnapshot sfiSnapName)) >>= \case
             -- exists, up to date, no force-updated requested; nothing to do
             Just (Entity _key snap)
-                | snapshotUpdatedOn snap == Just sfiUpdatedOn && not forceUpdate -> do
-                    logInfo $ mkLogMsg "already exists and is up to date."
+                | snapshotUpdatedOn snap == Just sfiUpdatedOn && not forceUpdate ->
                     return NothingToDo
             -- exists but updatedOn was not previously set.
             Just entity@(Entity _key snap)
@@ -546,8 +545,8 @@ decideOnSnapshotUpdate SnapshotFileInfo {sfiSnapName, sfiUpdatedOn, sfiSnapshotF
             Nothing -> maybe NoSnapshotFile DoesntExist <$> sfiSnapshotFileGetter
     -- Add new snapshot to the database, when necessary
     case mKeySnapFile of
-        NothingToDo -> return Nothing
-        NoSnapshotFile -> return Nothing
+        NothingToDo -> Nothing <$ logInfo (mkLogMsg "already exists and is up to date.")
+        NoSnapshotFile -> Nothing <$ logWarn (mkLogMsg "has no (readable?) snapshot file.")
         NeedsUpdate (Entity oldSnapKey oldSnap) sf@SnapshotFile {sfCompiler, sfPublishDate}
             | Just publishDate <- sfPublishDate -> do
                 let updatedSnap =