From c9eb8455687bfae3f7a02957880b59e2d340a896 Mon Sep 17 00:00:00 2001
From: belevy <benjaminlevy007@gmail.com>
Date: Tue, 19 Jan 2021 09:51:23 -0600
Subject: [PATCH] Remove EOrderByRandom, calling distinctOnOrderBy with rand
 will choke the db but you shouldnt be using rand anyway. distinctOnOrderBy
 seems dangerous though

---
 src/Database/Esqueleto/Internal/Internal.hs | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/Database/Esqueleto/Internal/Internal.hs b/src/Database/Esqueleto/Internal/Internal.hs
index b47b958..bdfe5e0 100644
--- a/src/Database/Esqueleto/Internal/Internal.hs
+++ b/src/Database/Esqueleto/Internal/Internal.hs
@@ -364,14 +364,12 @@ distinctOnOrderBy exprs act =
   where
     toDistinctOn :: SqlExpr OrderBy -> SqlExpr DistinctOn
     toDistinctOn (ERaw m f) = ERaw m f
-    toDistinctOn EOrderRandom =
-        error "We can't select distinct by a random order!"
 
 -- | @ORDER BY random()@ clause.
 --
 -- @since 1.3.10
 rand :: SqlExpr OrderBy
-rand = EOrderRandom
+rand = ERaw noMeta $ \_ _ -> ("RANDOM()", []) 
 
 -- | @HAVING@.
 --
@@ -2071,8 +2069,6 @@ data SqlExpr a where
     -- interpolated by the SQL backend.
     ERaw     :: SqlExprMeta -> (NeedParens -> IdentInfo -> (TLB.Builder, [PersistValue])) -> SqlExpr a 
 
-    EOrderRandom :: SqlExpr OrderBy
-
     -- A 'SqlExpr' accepted only by 'set'.
     ESet :: (SqlExpr (Entity val) -> SqlExpr (Value ())) -> SqlExpr (Update val)
 
@@ -2909,7 +2905,6 @@ makeOrderByNoNewline info os = first ("ORDER BY " <>) . uncommas' $ concatMap mk
   where
     mk :: OrderByClause -> [(TLB.Builder, [PersistValue])]
     mk (ERaw _ f) = [f Never info]
-    mk EOrderRandom = [first (<> "RANDOM()") mempty]
 
     orderByType ASC  = " ASC"
     orderByType DESC = " DESC"
@@ -2920,8 +2915,6 @@ makeOrderBy info is =
     let (tlb, vals) = makeOrderByNoNewline info is
     in ("\n" <> tlb, vals)
 
-{-# DEPRECATED EOrderRandom "Since 2.6.0: `rand` ordering function is not uniform across all databases! To avoid accidental partiality it will be removed in the next major version." #-}
-
 makeLimit :: IdentInfo -> LimitClause -> [OrderByClause] -> (TLB.Builder, [PersistValue])
 makeLimit (conn, _) (Limit ml mo) orderByClauses =
     let limitRaw = connLimitOffset conn (v ml, v mo) hasOrderClause "\n"