From 79b4ade4a529d5a99450243a5e3c37d5d5aa5506 Mon Sep 17 00:00:00 2001 From: parsonsmatt Date: Thu, 20 May 2021 10:20:10 -0600 Subject: [PATCH] remove failing test with bad behavior --- src/Database/Esqueleto/Internal/Internal.hs | 2 +- test/PostgreSQL/Test.hs | 20 -------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/src/Database/Esqueleto/Internal/Internal.hs b/src/Database/Esqueleto/Internal/Internal.hs index 1483860..82cb42b 100644 --- a/src/Database/Esqueleto/Internal/Internal.hs +++ b/src/Database/Esqueleto/Internal/Internal.hs @@ -3003,7 +3003,7 @@ makeGroupBy info (GroupBy fields) = first ("\nGROUP BY " <>) build match :: SomeValue -> (TLB.Builder, [PersistValue]) match (SomeValue (ERaw _ f)) = f info - match (SomeValue (ECompositeKey f)) = (mconcat $ f info, mempty) + match (SomeValue (ECompositeKey f)) = (uncommas $ f info, mempty) match (SomeValue (EAliasedValue i _)) = aliasedValueIdentToRawSql i info match (SomeValue (EValueReference i i')) = valueReferenceToRawSql i i' info diff --git a/test/PostgreSQL/Test.hs b/test/PostgreSQL/Test.hs index c13cbd9..d36ebf8 100644 --- a/test/PostgreSQL/Test.hs +++ b/test/PostgreSQL/Test.hs @@ -1423,26 +1423,6 @@ main = do testJSONInsertions testJSONOperators testLateralQuery - testUpdateWithExperimental - -testUpdateWithExperimental :: Spec -testUpdateWithExperimental = fdescribe "Update/Experimental" $ do - it "works" $ do - run $ do - p1k <- insert p1 - updateRethrowingQuery $ \p -> do - (p0 :& p1) <- Experimental.from $ - Table @Person - `InnerJoin` - Table @Person - `Experimental.on` do - \(p0 :& p1) -> - p0 ^. PersonName ==. p1 ^. PersonName - - set p [ PersonName =. val "asdf" ] - where_ $ p0 ^. PersonName ==. p ^. PersonName - - run, runSilent, runVerbose :: Run runSilent act = runNoLoggingT $ run_worker act