From 149bfa601081c27013811498fa507a83f5ce87ea Mon Sep 17 00:00:00 2001
From: Vincent Hanquez <vincent@snarc.org>
Date: Tue, 29 Mar 2016 07:17:24 +0100
Subject: [PATCH] [HKDF] document a bit better extractSkip

---
 Crypto/KDF/HKDF.hs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Crypto/KDF/HKDF.hs b/Crypto/KDF/HKDF.hs
index 6c73515..0b95601 100644
--- a/Crypto/KDF/HKDF.hs
+++ b/Crypto/KDF/HKDF.hs
@@ -7,10 +7,9 @@
 --
 -- Key Derivation Function based on HMAC
 --
--- See rfc5869
+-- See RFC5869
 --
 {-# LANGUAGE BangPatterns #-}
-{-# LANGUAGE GeneralizedNewtypeDeriving #-}
 module Crypto.KDF.HKDF
     ( PRK
     , extract
@@ -35,7 +34,10 @@ extract :: (HashAlgorithm a, ByteArrayAccess salt, ByteArrayAccess ikm)
         -> PRK a -- ^ Pseudo random key
 extract salt ikm = PRK $ hmac salt ikm
 
--- | Create a PRK directly from the input key material, skipping any hmacing
+-- | Create a PRK directly from the input key material.
+--
+-- Only use when guaranteed to have a good quality and random data to use directly as key.
+-- This effectively skip a HMAC with key=salt and data=key.
 extractSkip :: (HashAlgorithm a, ByteArrayAccess ikm)
             => ikm
             -> PRK a
@@ -74,4 +76,3 @@ expand prkAt infoAt outputLength =
                 r       = n - hashLen
              in (if n >= hashLen then ti else B.take n ti)
               : loop hF ti r (i+1)
-