refactor(csv): change new user default to xlsx working now

src/Handler/LMS/Users.hs

@@ -177,7 +177,8 @@ getLmsUsersDirectR sid qsh = do
       --csvRenderedHeader = lmsUserTableCsvHeader
       --cvsRendered = CsvRendered {..}
       csvRendered = toCsvRendered lmsUserTableCsvHeader $ lmsUser2csv cutoff . entityVal <$> lms_users
-      fmtOpts = def { csvIncludeHeader  = lmsDownloadHeader
+      fmtOpts = (review csvPreset CsvPresetRFC)
+                    { csvIncludeHeader  = lmsDownloadHeader
                     , csvDelimiter      = lmsDownloadDelimiter
                     , csvUseCrLf        = lmsDownloadCrLf
                     }

src/Handler/SAP.hs

@@ -97,7 +97,8 @@ getQualificationSAPDirectR = do
       , qual      Ex.^. QualificationSapId
       )    
   let csvRendered = toCsvRendered sapUserTableCsvHeader $ sapRes2csv qualUsers
-      fmtOpts = def { csvIncludeHeader  = True
+      fmtOpts = (review csvPreset CsvPresetRFC)
+                    { csvIncludeHeader  = True
                     , csvDelimiter      = ','
                     , csvUseCrLf        = True
                     }

src/Handler/Utils/LMS.hs

@@ -45,7 +45,8 @@ getLmsCsvDecoder :: (MonadHandler m, HandlerSite m ~ UniWorX, MonadThrow m, From
 getLmsCsvDecoder = do
   LmsConf{..} <- getsYesod $ view _appLmsConf
   if  | Just upDelim <- lmsUploadDelimiter -> do
-        let fmtOpts = def { csvDelimiter     = upDelim
+        let fmtOpts = (review csvPreset CsvPresetRFC)
+                          { csvDelimiter     = upDelim
                           , csvIncludeHeader = lmsUploadHeader
                           }
             csvOpts = def { csvFormat = fmtOpts }

src/Model/Types/Csv.hs

@@ -85,7 +85,7 @@ instance Default CsvOptions where
     }
 
 instance Default CsvFormatOptions where
-  def = CsvXlsxFormatOptions -- csvPreset # CsvPresetRFC
+  def = csvPreset # CsvPresetRFC -- changing the default here to CsvPresetXlsx will cause internal server errors to to partial record selectors failing
 
 data CsvPreset = CsvPresetRFC
                | CsvPresetXlsx

src/Utils/Users.hs

@@ -73,7 +73,7 @@ addNewUser AddUserData{..} = do
       , userExamOfficeGetLabels     = userDefaultExamOfficeGetLabels
       , userNotificationSettings    = def
       , userLanguages               = Nothing
-      , userCsvOptions              = def
+      , userCsvOptions              = def { csvFormat = review csvPreset CsvPresetXlsx }
       , userTokensIssuedAfter       = Nothing
       , userCreated                 = now
       , userLastLdapSynchronisation = Nothing