From e90d11682b7313725ab6941a1dca684d5ea955e5 Mon Sep 17 00:00:00 2001 From: "Jost, Steffen" Date: Fri, 10 Jan 2025 16:49:53 +0100 Subject: [PATCH] fix(lms): eliminate unlikely possible discrepancy for LMS deletion indicator It was theoretically possible for LMS Learner deletion tag to be not correctly shown in LMS table. Also see #2605 for further related issues. --- src/Handler/Utils/LMS.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Handler/Utils/LMS.hs b/src/Handler/Utils/LMS.hs index e6f35e8e9..06fd53a7b 100644 --- a/src/Handler/Utils/LMS.hs +++ b/src/Handler/Utils/LMS.hs @@ -135,7 +135,7 @@ lmsDeletionDate mbMaxAuditMonths = do -- | Decide whether LMS platform should delete an identifier lmsUserToDeleteExpr :: UTCTime -> E.SqlExpr (Entity LmsUser) -> E.SqlExpr (E.Value Bool) lmsUserToDeleteExpr cutoff lmslist = E.isNothing (lmslist E.^. LmsUserEnded) - E.&&. E.isJust (lmslist E.^. LmsUserStatus) + -- E.&&. E.isJust (lmslist E.^. LmsUserStatus) E.&&. E.isJust (lmslist E.^. LmsUserStatusDay) E.&&. lmslist E.^. LmsUserStatusDay E.<=. E.justVal cutoff