From 5e6de82e1d9cd6b4f2305d94388f94c8b2152d43 Mon Sep 17 00:00:00 2001
From: Gregor Kleen <gkleen@yggdrasil.li>
Date: Sat, 29 Dec 2018 14:51:08 +0100
Subject: [PATCH] Fix accidental form nesting

---
 src/Handler/Utils/Table/Pagination.hs | 19 +++++++-------
 templates/table/colonnade.hamlet      | 37 ++++++++++++++-------------
 templates/table/layout.hamlet         |  5 ++--
 3 files changed, 31 insertions(+), 30 deletions(-)

diff --git a/src/Handler/Utils/Table/Pagination.hs b/src/Handler/Utils/Table/Pagination.hs
index 31945a503..15716149a 100644
--- a/src/Handler/Utils/Table/Pagination.hs
+++ b/src/Handler/Utils/Table/Pagination.hs
@@ -679,17 +679,18 @@ dbTable PSValidator{..} dbtable@DBTable{ dbtIdent = dbtIdent'@(toPathPiece -> db
         let attrs = cell' ^. cellAttrs
         return $(widgetFile "table/cell/body")
 
-      let table = $(widgetFile "table/colonnade")
-          pageCount
-            | PagesizeLimit l <- psLimit
-            = max 1 . ceiling $ rowCount % l
-            | otherwise
-            = 1
-          pageNumbers = [0..pred pageCount]
+      return $(widgetFile "table/colonnade")
 
-      return $(widgetFile "table/layout")
+    pageCount
+      | PagesizeLimit l <- psLimit
+      = max 1 . ceiling $ rowCount % l
+      | otherwise
+      = 1
+    pageNumbers = [0..pred pageCount]
 
-  bool (dbHandler (Proxy @m) (Proxy @x) $ (\table -> $(widgetFile "table/layout-wrapper")) . dbsFilterLayout filterWdgt filterEnc rawAction) (sendResponse <=< tblLayout . dbsFilterLayout filterWdgt filterEnc rawAction <=< dbWidget (Proxy @m) (Proxy @x)) psShortcircuit <=< runDBTable dbtable paginationInput currentKeys . fmap swap $ runWriterT table'
+    uiLayout table = dbsFilterLayout filterWdgt filterEnc rawAction $(widgetFile "table/layout")
+
+  bool (dbHandler (Proxy @m) (Proxy @x) $ (\table -> $(widgetFile "table/layout-wrapper")) . uiLayout) (sendResponse <=< tblLayout . uiLayout <=< dbWidget (Proxy @m) (Proxy @x)) psShortcircuit <=< runDBTable dbtable paginationInput currentKeys . fmap swap $ runWriterT table'
   where
     tblLayout :: forall m'. (MonadHandler m', HandlerSite m' ~ UniWorX) => Widget -> m' Html
     tblLayout tbl' = do
diff --git a/templates/table/colonnade.hamlet b/templates/table/colonnade.hamlet
index 828b64111..9ccea4ef8 100644
--- a/templates/table/colonnade.hamlet
+++ b/templates/table/colonnade.hamlet
@@ -1,20 +1,21 @@
 $newline never
-<table *{dbsAttrs'}>
-  $maybe wHeaders' <- wHeaders
-    <thead>
-      <tr .table__row.table__row--head>
-        $forall widget <- wHeaders'
-          $# cell/header.hamlet
-          ^{widget}
-  $nothing
-  <tbody>
-    $if null wRows && (dbsEmptyStyle == DBESHeading)
-      <tr .table__row>
-        <td .table__td colspan=#{show columnCount}>
-          _{dbsEmptyMessage}
-    $else
-      $forall row <- wRows
-        <tr .table__row>
-          $forall widget <- row
-            $# cell/body.hamlet
+<div .scrolltable>
+  <table *{dbsAttrs'}>
+    $maybe wHeaders' <- wHeaders
+      <thead>
+        <tr .table__row.table__row--head>
+          $forall widget <- wHeaders'
+            $# cell/header.hamlet
             ^{widget}
+    $nothing
+    <tbody>
+      $if null wRows && (dbsEmptyStyle == DBESHeading)
+        <tr .table__row>
+          <td .table__td colspan=#{show columnCount}>
+            _{dbsEmptyMessage}
+      $else
+        $forall row <- wRows
+          <tr .table__row>
+            $forall widget <- row
+              $# cell/body.hamlet
+              ^{widget}
diff --git a/templates/table/layout.hamlet b/templates/table/layout.hamlet
index 2d662b885..bc0fbd289 100644
--- a/templates/table/layout.hamlet
+++ b/templates/table/layout.hamlet
@@ -1,9 +1,8 @@
 $newline never
-$if null wRows && (dbsEmptyStyle == DBESNoHeading)
+$if null rows && (dbsEmptyStyle == DBESNoHeading)
   _{dbsEmptyMessage}
 $else
-  <div .scrolltable>
-    ^{table}
+  ^{table}
   $if pageCount > 1
     <div .pagination>
       <form .pagesize method=GET enctype=#{pagesizeEnc} action=#{rawAction}>