From b0ed911849b17dd264c445b162fd2a3c4415f744 Mon Sep 17 00:00:00 2001 From: Sarah Vaupel Date: Wed, 3 Jul 2019 10:05:53 +0200 Subject: [PATCH] refactor(displayable): removed resolved TODOs --- src/Handler/Utils/Table/Cells.hs | 2 +- src/Model.hs | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/Handler/Utils/Table/Cells.hs b/src/Handler/Utils/Table/Cells.hs index 880720fed..2e8e53db8 100644 --- a/src/Handler/Utils/Table/Cells.hs +++ b/src/Handler/Utils/Table/Cells.hs @@ -237,7 +237,7 @@ submissionCell crse shn sid = csh = crse ^. _3 mkCid = encrypt sid mkRoute cid = CSubmissionR tid ssh csh shn cid SubShowR - mkText = toWgt -- display2widget -- TODO: replace with toWgt once there is a ToMarkup instance for CryptoIDs + mkText = toWgt in anchorCellM' mkCid mkRoute mkText correctorStateCell :: IsDBTable m a => SheetCorrector -> DBCell m a diff --git a/src/Model.hs b/src/Model.hs index d68e7806e..787bf9b77 100644 --- a/src/Model.hs +++ b/src/Model.hs @@ -53,15 +53,10 @@ submissionRatingDone :: Submission -> Bool submissionRatingDone Submission{..} = isJust submissionRatingTime -- ToMarkup instances for displaying certain database primary keys --- TODO: work in progress, populate with more instances -- TODO: is there a better place for this? instance ToMarkup (Key School) where toMarkup = toMarkup . unSchoolKey instance ToMarkup (Key Term) where - toMarkup = toMarkup . termToText . unTermKey - --- TODO: unfinished --- instance ToMarkup (Key Submission) where --- toMarkup = toMarkup . unSubmissionKey \ No newline at end of file + toMarkup = toMarkup . termToText . unTermKey \ No newline at end of file