From 9ca0c1b0e3ff8207536ae98133cdd5380834350b Mon Sep 17 00:00:00 2001 From: Gregor Kleen Date: Wed, 5 Dec 2018 12:06:16 +0100 Subject: [PATCH] Be less restrictive when creating submissions Allow groups larger than maximum group submission size in principle --- src/Handler/Corrections.hs | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/Handler/Corrections.hs b/src/Handler/Corrections.hs index 4984c421a..63867d4d4 100644 --- a/src/Handler/Corrections.hs +++ b/src/Handler/Corrections.hs @@ -680,17 +680,15 @@ postCorrectionsCreateR = do -> let sheetGroupDesc = Text.intercalate ", " $ map (review _PseudonymText . sheetPseudonymPseudonym) spGroup in case sheetGrouping of - Arbitrary maxSize - | genericLength spGroup > maxSize - -> addMessageI Error $ MsgSheetGroupTooLarge sheetGroupDesc - | otherwise - -> do - subId <- insert submissionPrototype - void . insert $ SubmissionEdit uid now subId - insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser - { submissionUserUser = sheetPseudonymUser - , submissionUserSubmission = subId - } + Arbitrary maxSize -> do + subId <- insert submissionPrototype + void . insert $ SubmissionEdit uid now subId + insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser + { submissionUserUser = sheetPseudonymUser + , submissionUserSubmission = subId + } + when (genericLength spGroup > maxSize) $ + addMessageI Warning $ MsgSheetGroupTooLarge sheetGroupDesc RegisteredGroups -> do groups <- E.select . E.from $ \submissionGroup -> do E.where_ . E.exists . E.from $ \submissionGroupUser ->