From 09e681eeb1ec77a1f8c263978322026683aae031 Mon Sep 17 00:00:00 2001 From: Felix Hamann Date: Fri, 14 Jun 2019 00:05:23 +0200 Subject: [PATCH] fix(fe-check-all): use arrow fn to keep scope in event listeners --- frontend/src/utils/check-all/check-all.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/src/utils/check-all/check-all.js b/frontend/src/utils/check-all/check-all.js index 46194c029..340dca0b1 100644 --- a/frontend/src/utils/check-all/check-all.js +++ b/frontend/src/utils/check-all/check-all.js @@ -36,7 +36,7 @@ export class CheckAll { } destroy() { - console.log('TBD: Destroy CheckAll'); + this._checkAllCheckbox.destroy(); } _getCheckboxId() { @@ -95,7 +95,7 @@ export class CheckAll { // set up new checkbox this._app.utilRegistry.setupAll(th); - this._checkAllCheckbox.addEventListener('input', this._onCheckAllCheckboxInput); + this._checkAllCheckbox.addEventListener('input', () => this._onCheckAllCheckboxInput()); this._setupCheckboxListeners(); } @@ -108,7 +108,7 @@ export class CheckAll { return cell.querySelector(CHECKBOX_SELECTOR); }) .forEach((checkbox) => { - checkbox.addEventListener('input', this.updateCheckAllCheckboxState); + checkbox.addEventListener('input', () => this._updateCheckAllCheckboxState()); }); }