From 8e0c379c71ca1226590b333f9a740c6cc0aa98be Mon Sep 17 00:00:00 2001
From: Gregor Kleen <kleen@cip.ifi.lmu.de>
Date: Wed, 17 Jul 2019 11:49:19 +0200
Subject: [PATCH] fix(submissions): only notify submittors if rating is done

---
 src/Handler/Utils/Submission.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Handler/Utils/Submission.hs b/src/Handler/Utils/Submission.hs
index 812c2ff66..6d6879648 100644
--- a/src/Handler/Utils/Submission.hs
+++ b/src/Handler/Utils/Submission.hs
@@ -522,7 +522,7 @@ sinkSubmission userId mExists isUpdate = do
   
           mapM_ throwM $ validateRating sheetType r'
 
-          when (isNothing submissionRatingTime) $ tellSt mempty { sinkSubmissionNotifyRating = Any True }
+          when (submissionRatingDone r') $ tellSt mempty { sinkSubmissionNotifyRating = Any True }
           lift $ update submissionId
             [ SubmissionRatingPoints  =. ratingPoints
             , SubmissionRatingComment =. ratingComment