diff --git a/messages/uniworx/categories/jobs_handler/de-de-formal.msg b/messages/uniworx/categories/jobs_handler/de-de-formal.msg index 3deea807d..2f14791ac 100644 --- a/messages/uniworx/categories/jobs_handler/de-de-formal.msg +++ b/messages/uniworx/categories/jobs_handler/de-de-formal.msg @@ -12,9 +12,9 @@ CommUndisclosedRecipients: Verborgene Empfänger:innen CommAllRecipients: alle-empfaenger CommAllRecipientsSheet: Empfänger:innen ResetPassword: FRADrive-Passwort ändern bzw. setzen -MailSubjectChangeUserDisplayEmail: Diese E-Mail-Adresse in FRADrive veröffentlichen -MailIntroChangeUserDisplayEmail displayEmail@UserEmail: Der oben genannte Benutzer/Die oben genannte Benutzerin möchte „#{displayEmail}“ als öffentliche Adresse, assoziiert mit sich selbst, angeben. Wenn Sie diese Aktion nicht selbst ausgelöst haben, ignorieren Sie diese Mitteilung bitte! -MailTitleChangeUserDisplayEmail displayName@Text: #{displayName} möchte diese E-Mail-Adresse in FRADrive veröffentlichen +MailSubjectChangeUserDisplayEmail: E-Mail-Adresse in FRADrive verwenden +MailIntroChangeUserDisplayEmail displayEmail@UserEmail: Der oben genannte Benutzer/Die oben genannte Benutzerin möchte „#{displayEmail}“ als E-Mail-Adresse in FRADrive verwenden. Wenn Sie diese Aktion nicht selbst ausgelöst haben, ignorieren Sie diese Mitteilung bitte! +MailTitleChangeUserDisplayEmail displayName@Text: #{displayName} möchte diese E-Mail-Adresse in FRADrive verwenden CommCourseSubject: Kursmitteilung InvitationAcceptDecline: Einladung annehmen/ablehnen InvitationFromTip displayName@Text: Sie erhalten diese Einladung, weil #{displayName} ihren Versand in FRADrive ausgelöst hat. diff --git a/messages/uniworx/categories/jobs_handler/en-eu.msg b/messages/uniworx/categories/jobs_handler/en-eu.msg index 2169d8d2d..77e0a96f9 100644 --- a/messages/uniworx/categories/jobs_handler/en-eu.msg +++ b/messages/uniworx/categories/jobs_handler/en-eu.msg @@ -12,9 +12,9 @@ CommUndisclosedRecipients: Undisclosed recipients CommAllRecipients: all-recipients CommAllRecipientsSheet: Recipients ResetPassword: Reselt FRADrive password -MailSubjectChangeUserDisplayEmail: Publishing this email address in FRADrive -MailIntroChangeUserDisplayEmail displayEmail: The user mentioned above wants to publish “#{displayEmail}” as their own email address. If you have not caused this email to be sent, please ignore it! -MailTitleChangeUserDisplayEmail displayName: #{displayName} wants to publish this email address as their own in FRADrive +MailSubjectChangeUserDisplayEmail: Set email address in FRADrive +MailIntroChangeUserDisplayEmail displayEmail: The user mentioned above wants to set “#{displayEmail}” as their own email address. If you have not caused this email to be sent, please ignore it! +MailTitleChangeUserDisplayEmail displayName: #{displayName} wants to set this email address as their own in FRADrive CommCourseSubject: Course message InvitationAcceptDecline: Accept/Decline invitation InvitationFromTip displayName: You are receiving this invitation because #{displayName} has caused it to be sent from within FRADrive. diff --git a/messages/uniworx/categories/settings/de-de-formal.msg b/messages/uniworx/categories/settings/de-de-formal.msg index f04b1cde1..189f226e5 100644 --- a/messages/uniworx/categories/settings/de-de-formal.msg +++ b/messages/uniworx/categories/settings/de-de-formal.msg @@ -8,9 +8,11 @@ FormPersonalAppearance: Öffentliche Daten UserDisplayName: Angezeigter Name UserDisplayNameInvalid: Angezeigter Name erfüllt nicht die Vorgaben UserDisplayNameRulesBelow: Vorgaben für den angezeigten Namen finden sich weiter unten auf der Seite -UserDisplayEmail: Angezeigte E-Mail-Adresse -UserDisplayEmailTip: Diese Adresse wird in öffentlich zugänglichen Teilen des Systems im Zusammenhang mit Ihrem Namen angezeigt. Benachrichtigungen und andere Kommunikation von Uni2work und Nutzer:innen mit erweiterten Rechten erhalten sie stets, unabhängig von dieser Einstellung, an die in Ihren Persönlichen Daten hinterlegte primäre Adresse. -UserDisplayEmailChangeSent displayEmail@UserEmail: Anweisungen zum Ändern der angezeigten E-Mail-Adresse wurden an „#{displayEmail}” versandt +UserSystemEmail: System E-Mail Adresse +UserDisplayEmail: E-Mail-Adresse +UserDisplayEmailTip: Diese Adresse wird in öffentlich zugänglichen Teilen des Systems im Zusammenhang mit Ihrem Namen angezeigt. Falls diese ungültig ist gehen Benachrichtigungen an ihre System E-Mail-Adresse. +UserDisplayEmailChangeSent displayEmail@UserEmail: Anweisungen zum Ändern der E-Mail-Adresse wurden an „#{displayEmail}” versandt +UserDisplayEmailChanged: Öffentliche E-Mail-Adresse erfolgreich gesetzt FormCosmetics: Oberfläche @@ -94,7 +96,6 @@ ProfileLdapPrimaryKey: LDAP-Primärschlüssel NotificationSettingsUpdate: Benachrichtigungs-Einstellungen erfolgreich gespeichert NotificationSettingsHeading displayName@Text: Benachrichtigungs-Einstellungen für #{displayName} -UserDisplayEmailChanged: Öffentliche E-Mail-Adresse erfolgreich gesetzt FavouriteVisited: Kürzlich besucht FavouriteParticipant: Ihre Kurse FavouriteManual: Favoriten diff --git a/messages/uniworx/categories/settings/en-eu.msg b/messages/uniworx/categories/settings/en-eu.msg index 3c63fc06a..6dbf5dd95 100644 --- a/messages/uniworx/categories/settings/en-eu.msg +++ b/messages/uniworx/categories/settings/en-eu.msg @@ -8,9 +8,11 @@ FormPersonalAppearance: Public data UserDisplayName: Display name UserDisplayNameInvalid: Display name does not comply with specification UserDisplayNameRulesBelow: Specifications of what can be a display name can be found below -UserDisplayEmail: Display email -UserDisplayEmailTip: This email address may be displayed publicly alongside your display name. Notifications and other communication from Uni2work or users with elevated permissions are always sent to your primary email address as specified under "personal information". +UserSystemEmail: System Email address +UserDisplayEmail: Email +UserDisplayEmailTip: This email address may be displayed publicly alongside your display name. If invalid, notifications will be sent to your system email address instead. UserDisplayEmailChangeSent displayEmail: Instructions to change your display email have been sent to “#{displayEmail}”. +UserDisplayEmailChanged: Successfully set display email FormCosmetics: Interface @@ -94,7 +96,6 @@ ProfileLdapPrimaryKey: LDAP primary key NotificationSettingsUpdate: Successfully updated notification settings NotificationSettingsHeading displayName: Notification settings for #{displayName} -UserDisplayEmailChanged: Successfully set display email FavouriteVisited: Visited FavouriteParticipant: Your courses FavouriteManual: Favourites diff --git a/messages/uniworx/categories/user/de-de-formal.msg b/messages/uniworx/categories/user/de-de-formal.msg index 459ba2255..85ef0f47b 100644 --- a/messages/uniworx/categories/user/de-de-formal.msg +++ b/messages/uniworx/categories/user/de-de-formal.msg @@ -6,8 +6,8 @@ AdminUserTitle: Titel AdminUserFirstName: Vorname AdminUserSurname: Nachname AdminUserDisplayName: Anzeige-Name -AdminUserEmail: E-Mail-Adresse -AdminUserDisplayEmail: Anzeige-E-Mail +AdminUserEmail: System E-Mail +AdminUserDisplayEmail: E-Mail-Adresse AdminUserIdent: Identifikation AdminUserAuth: Authentifizierung AdminUserAuthTooltip: Abhängig von der Auswahl werden neue Benutzer über ihr neues FRADrive Konto benachrichtigt. diff --git a/messages/uniworx/categories/user/en-eu.msg b/messages/uniworx/categories/user/en-eu.msg index 9d51a29a3..8fd7c0333 100644 --- a/messages/uniworx/categories/user/en-eu.msg +++ b/messages/uniworx/categories/user/en-eu.msg @@ -6,8 +6,8 @@ AdminUserTitle: Title AdminUserFirstName: Given name AdminUserSurname: Surname AdminUserDisplayName: Display name -AdminUserEmail: Email address -AdminUserDisplayEmail: Display email +AdminUserEmail: System Email address +AdminUserDisplayEmail: Email address AdminUserIdent: Identification AdminUserAuth: Authentication AdminUserAuthTooltip: New users may be notified about their FRADrive account depending on this choice. diff --git a/messages/uniworx/utils/navigation/breadcrumbs/de-de-formal.msg b/messages/uniworx/utils/navigation/breadcrumbs/de-de-formal.msg index 15be16d0d..684e91f5e 100644 --- a/messages/uniworx/utils/navigation/breadcrumbs/de-de-formal.msg +++ b/messages/uniworx/utils/navigation/breadcrumbs/de-de-formal.msg @@ -88,7 +88,7 @@ BreadcrumbVersion: Versionsgeschichte BreadcrumbHelp: Hilfe BreadcrumbHealth: Instanz-Zustand BreadcrumbInstance: Instanz-Identifikation -BreadcrumbUserDisplayEmail: Angezeigte E-Mail-Adresse +BreadcrumbUserDisplayEmail: E-Mail-Adresse BreadcrumbProfileData: Persönliche Daten BreadcrumbAuthPreds: Authorisierungseinstellungen BreadcrumbTermShow: Semester diff --git a/messages/uniworx/utils/navigation/breadcrumbs/en-eu.msg b/messages/uniworx/utils/navigation/breadcrumbs/en-eu.msg index bce374d79..705ec1d6c 100644 --- a/messages/uniworx/utils/navigation/breadcrumbs/en-eu.msg +++ b/messages/uniworx/utils/navigation/breadcrumbs/en-eu.msg @@ -88,7 +88,7 @@ BreadcrumbVersion: Version history BreadcrumbHelp: Support BreadcrumbHealth: Instance health BreadcrumbInstance: Instance identification -BreadcrumbUserDisplayEmail: Display email +BreadcrumbUserDisplayEmail: Email address BreadcrumbProfileData: Personal information BreadcrumbAuthPreds: Authorisation settings BreadcrumbTermShow: Semesters diff --git a/models/avs.model b/models/avs.model index 371a3dae0..45f2321d7 100644 --- a/models/avs.model +++ b/models/avs.model @@ -23,6 +23,7 @@ UserAvs -- Multiple UserAvsCards per UserAvs is possible and not too uncommon. -- Purpose of saving cards is to detect external changes in qualifications and postal addresses +-- TODO: This table will be deleted if AVS CR3 SCF-165 is implemented UserAvsCard personId AvsPersonId cardNo AvsFullCardNo diff --git a/models/users.model b/models/users.model index 77a330744..38305c4f0 100644 --- a/models/users.model +++ b/models/users.model @@ -88,8 +88,8 @@ UserGroupMember UserCompany user UserId company CompanyId OnDeleteCascade OnUpdateCascade - supervisor Bool -- should this user be made supervisor for all _new_ users associated with this company? - supervisorReroute Bool default=true -- if supervisor is true, should this supervisor receive email for _new_ company users? + supervisor Bool default=false -- should this user be made supervisor for all _new_ users associated with this company? + supervisorReroute Bool default=false -- if supervisor is true, should this supervisor receive email for _new_ company users? UniqueUserCompany user company -- a user may belong to multiple companies, but to each one only once deriving Generic UserSupervisor diff --git a/src/Foundation/Instances.hs b/src/Foundation/Instances.hs index 5881af647..b7d6a555b 100644 --- a/src/Foundation/Instances.hs +++ b/src/Foundation/Instances.hs @@ -259,8 +259,8 @@ instance YesodMail UniWorX where return user let recipUserCompare = mconcat [ comparing $ Down . (== recipAddr) . userIdent . entityVal - , comparing $ Down . (== recipAddr) . userEmail . entityVal , comparing $ Down . (== recipAddr) . userDisplayEmail . entityVal + , comparing $ Down . (== recipAddr) . userEmail . entityVal ] return $ if | ( bU : us ) <- sortBy recipUserCompare recipUsers diff --git a/src/Handler/Course/Edit.hs b/src/Handler/Course/Edit.hs index 1c0a6b5b6..127056489 100644 --- a/src/Handler/Course/Edit.hs +++ b/src/Handler/Course/Edit.hs @@ -117,7 +117,7 @@ makeCourseForm miButtonAction template = identifyForm FIDcourse . validateFormDB miCell :: ListPosition -> Either UserEmail UserId -> Maybe (Maybe LecturerType) -> (Text -> Text) -> Form (Maybe LecturerType) miCell _ (Right lid) defType nudge = \csrf -> do (lrwRes,lrwView) <- mreq (selectField optionsFinite) (fslI MsgCourseLecturerType & addName (nudge "lecturer-type")) (join defType) - User{userEmail, userDisplayName, userSurname} <- liftHandler . runDB $ get404 lid + usr <- liftHandler . runDB $ get404 lid let lrwView' = $(widgetFile "course/lecturerMassInput/cellKnown") return (Just <$> lrwRes,lrwView') miCell _ (Left lEmail) defType nudge = \csrf -> do diff --git a/src/Handler/Course/Show.hs b/src/Handler/Course/Show.hs index ed75bad81..618a7559c 100644 --- a/src/Handler/Course/Show.hs +++ b/src/Handler/Course/Show.hs @@ -168,7 +168,7 @@ getCShowR tid ssh csh = do tutTutors <- fmap (map $(unValueN 3)) . E.select . E.from $ \(tutor `E.InnerJoin` user) -> do E.on $ tutor E.^. TutorUser E.==. user E.^. UserId E.where_ $ tutor E.^. TutorTutorial E.==. E.val tutid - return (user E.^. UserEmail, user E.^. UserDisplayName, user E.^. UserSurname) + return (user E.^. UserDisplayEmail, user E.^. UserDisplayName, user E.^. UserSurname) return [whamlet| $newline never