chore(mail): revert supervisor rerouting at notification level

src/Jobs/Handler/SendNotification.hs

@@ -26,22 +26,23 @@ import Jobs.Handler.SendNotification.CourseRegistered
 import Jobs.Handler.SendNotification.SubmissionEdited
 import Jobs.Handler.SendNotification.Qualification 
 
+dispatchJobSendNotification :: UserId -> Notification -> JobHandler UniWorX
+dispatchJobSendNotification jRecipient jNotification = JobHandlerException $ 
+  $(dispatchTH ''Notification) jNotification jRecipient
+  
 {-
-  Notfications receive three arguments:
+IDEAS:
-    1) addressee, the person for whom the message truly is
+  1) change type of dispatchNotificationfunctions to take another argument in addition to
-    2) type of notification to be send
+      jRecipient jNotificiation
-    3) maybe supervisor, the person actually receiving the message
+  2) change mailT and sendPrintJob to account for supervisors
-
-
-    
--}
-
-- - TODO: check that we caught all calls to userMailT!!!
 
 dispatchJobSendNotification :: UserId -> Notification -> JobHandler UniWorX
 dispatchJobSendNotification jRecipient jNotification = JobHandlerException $ do 
+  -- TODO: this is a bad idea, since all notifications use jRecipient to generate the message body,
+  --       thus supervisors would receive all notifications with their own name inside!
   superVs <- runDB $ selectList [UserSupervisorUser ==. jRecipient, UserSupervisorRerouteNotifications ==. True] []
   if null superVs 
-    then $(dispatchTH ''Notification) jNotification jRecipient Nothing 
+    then $(dispatchTH ''Notification) jNotification jRecipient
     else forM_ superVs $ \Entity { entityVal = UserSupervisor { userSupervisorSupervisor = svr } } -> 
-            $(dispatchTH ''Notification) jNotification jRecipient (Just svr)
+            $(dispatchTH ''Notification) jNotification svr
+-}

src/Jobs/Handler/SendNotification/Allocation.hs

@@ -26,8 +26,8 @@ import qualified Database.Esqueleto.Legacy as E
 import qualified Database.Esqueleto.Utils as E
 
 
-dispatchNotificationAllocationStaffRegister :: Set AllocationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationStaffRegister :: Set AllocationId -> UserId -> Handler ()
-dispatchNotificationAllocationStaffRegister (otoList -> nAllocations) jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationAllocationStaffRegister (otoList -> nAllocations) jRecipient = userMailT jRecipient $ do
   allocs <- fmap (sortOn $ \Allocation{..} -> (allocationSchool, allocationName)) . liftHandler . runDB $ mapM getJust nAllocations
 
   replaceMailHeader "Auto-Submitted" $ Just "auto-generated"
@@ -42,8 +42,8 @@ dispatchNotificationAllocationStaffRegister (otoList -> nAllocations) jRecipient
       singleRegisterDeadline = maybe True (flip all (allocs ^.. folded . _allocationStaffRegisterTo) . (==)) $ allocs ^? _head . _allocationStaffRegisterTo
   addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/allocationStaffRegister.hamlet")
 
-dispatchNotificationAllocationRegister :: Set AllocationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationRegister :: Set AllocationId -> UserId -> Handler ()
-dispatchNotificationAllocationRegister (otoList -> nAllocations) jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationAllocationRegister (otoList -> nAllocations) jRecipient = userMailT jRecipient $ do
   allocs <- fmap (sortOn $ \Allocation{..} -> (allocationSchool, allocationName)) . liftHandler . runDB $ mapM getJust nAllocations
 
   replaceMailHeader "Auto-Submitted" $ Just "auto-generated"
@@ -58,7 +58,7 @@ dispatchNotificationAllocationRegister (otoList -> nAllocations) jRecipient jSup
       singleRegisterDeadline = maybe True (flip all (allocs ^.. folded . _allocationRegisterTo) . (==)) $ allocs ^? _head . _allocationRegisterTo
   addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/allocationRegister.hamlet")
 
-dispatchNotificationAllocationAllocation :: Set AllocationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationAllocation :: Set AllocationId -> UserId -> Handler ()
 dispatchNotificationAllocationAllocation (otoList -> nAllocations) jRecipient = do
   courses <- fmap (nubOrdOn $ views _2 entityKey) . runDB . E.select . E.from $ \(course `E.InnerJoin` allocationCourse `E.InnerJoin` allocation `E.InnerJoin` lecturer) -> do
     E.on $ lecturer E.^. LecturerCourse E.==. course E.^. CourseId
@@ -97,7 +97,7 @@ dispatchNotificationAllocationAllocation (otoList -> nAllocations) jRecipient =
 
     addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/allocationAllocation.hamlet")
 
-dispatchNotificationAllocationUnratedApplications :: Set AllocationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationUnratedApplications :: Set AllocationId -> UserId -> Handler ()
 dispatchNotificationAllocationUnratedApplications (otoList -> nAllocations) jRecipient = do
   courses <- fmap (nubOrdOn (views _2 entityKey) . over (traverse . _3) (fromIntegral . E.unValue)) . runDB . E.select . E.from $ \(course `E.InnerJoin` allocationCourse `E.InnerJoin` allocation `E.InnerJoin` lecturer) -> do
     E.on $ lecturer E.^. LecturerCourse E.==. course E.^. CourseId
@@ -142,8 +142,8 @@ dispatchNotificationAllocationUnratedApplications (otoList -> nAllocations) jRec
 
     addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/allocationUnratedApplications.hamlet")
 
-dispatchNotificationAllocationResults :: AllocationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationResults :: AllocationId -> UserId -> Handler ()
-dispatchNotificationAllocationResults nAllocation jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationAllocationResults nAllocation jRecipient = userMailT jRecipient $ do
   (Allocation{..}, lecturerResults, warnSubstituteCourses, participantResults) <- liftHandler . runDB $ do
     allocation <- getJust nAllocation
 
@@ -194,8 +194,8 @@ dispatchNotificationAllocationResults nAllocation jRecipient jSupervisor = super
   where
     studentFaqItems' = [FAQAllocationNoPlaces]
 
-dispatchNotificationAllocationNewCourse :: AllocationId -> CourseId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationAllocationNewCourse :: AllocationId -> CourseId -> UserId -> Handler ()
-dispatchNotificationAllocationNewCourse nAllocation nCourse jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationAllocationNewCourse nAllocation nCourse jRecipient = userMailT jRecipient $ do
   (Allocation{..}, Course{..}, hasApplied) <- liftHandler . runDB $ (,,)
     <$> getJust nAllocation
     <*> getJust nCourse

src/Jobs/Handler/SendNotification/CorrectionsAssigned.hs

@@ -16,7 +16,7 @@ import Handler.Utils.Mail
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationCorrectionsAssigned :: UserId -> SheetId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationCorrectionsAssigned :: UserId -> SheetId -> UserId -> Handler ()
 dispatchNotificationCorrectionsAssigned  nUser nSheet jRecipient = do
   (Course{..}, Sheet{..}, nbrSubs) <- runDB $ do
     sheet <- getJust nSheet

src/Jobs/Handler/SendNotification/CorrectionsNotDistributed.hs

@@ -13,7 +13,7 @@ import Handler.Utils.Mail
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationCorrectionsNotDistributed :: SheetId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationCorrectionsNotDistributed :: SheetId -> UserId -> Handler ()
 dispatchNotificationCorrectionsNotDistributed nSheet jRecipient = do
   (Course{..}, Sheet{..}, nbrSubs) <- runDB $ do
     sheet <- getJust nSheet

src/Jobs/Handler/SendNotification/CourseRegistered.hs

@@ -16,8 +16,8 @@ import Jobs.Handler.SendNotification.Utils
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationCourseRegistered :: UserId -> CourseId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationCourseRegistered :: UserId -> CourseId -> UserId -> Handler ()
-dispatchNotificationCourseRegistered nUser nCourse jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationCourseRegistered nUser nCourse jRecipient = userMailT jRecipient $ do
   (User{..}, Course{..}) <- liftHandler . runDB $ (,) <$> getJust nUser <*> getJust nCourse
 
   let isSelf = nUser == jRecipient

src/Jobs/Handler/SendNotification/ExamActive.hs

@@ -18,8 +18,8 @@ import Jobs.Handler.SendNotification.Utils
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationExamRegistrationActive :: ExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamRegistrationActive :: ExamId -> UserId -> Handler ()
-dispatchNotificationExamRegistrationActive nExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamRegistrationActive nExam jRecipient = userMailT jRecipient $ do
   (Course{..}, Exam{..}) <- liftHandler . runDB $ do
     exam <- getJust nExam
     course <- belongsToJust examCourse exam
@@ -38,8 +38,8 @@ dispatchNotificationExamRegistrationActive nExam jRecipient jSupervisor = superM
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/examRegistrationActive.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
-dispatchNotificationExamRegistrationSoonInactive :: ExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamRegistrationSoonInactive :: ExamId -> UserId -> Handler ()
-dispatchNotificationExamRegistrationSoonInactive nExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamRegistrationSoonInactive nExam jRecipient = userMailT jRecipient $ do
   (Course{..}, Exam{..}) <- liftHandler . runDB $ do
     exam <- getJust nExam
     course <- belongsToJust examCourse exam
@@ -58,8 +58,8 @@ dispatchNotificationExamRegistrationSoonInactive nExam jRecipient jSupervisor =
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/examRegistrationSoonInactive.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
-dispatchNotificationExamDeregistrationSoonInactive :: ExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamDeregistrationSoonInactive :: ExamId -> UserId -> Handler ()
-dispatchNotificationExamDeregistrationSoonInactive nExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamDeregistrationSoonInactive nExam jRecipient = userMailT jRecipient $ do
   (Course{..}, Exam{..}) <- liftHandler . runDB $ do
     exam <- getJust nExam
     course <- belongsToJust examCourse exam

src/Jobs/Handler/SendNotification/ExamOffice.hs

@@ -21,8 +21,8 @@ import qualified Data.CaseInsensitive as CI
 import qualified Data.Set as Set
 
 
-dispatchNotificationExamOfficeExamResults :: ExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamOfficeExamResults :: ExamId -> UserId -> Handler ()
-dispatchNotificationExamOfficeExamResults nExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamOfficeExamResults nExam jRecipient = userMailT jRecipient $ do
   (Course{..}, Exam{..}) <- liftHandler . runDB $ do
     exam <- getJust nExam
     course <- belongsToJust examCourse exam
@@ -41,12 +41,12 @@ dispatchNotificationExamOfficeExamResults nExam jRecipient jSupervisor = superMa
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/examOffice/examResults.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
-dispatchNotificationExamOfficeExamResultsChanged :: Set ExamResultId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamOfficeExamResultsChanged :: Set ExamResultId -> UserId -> Handler ()
-dispatchNotificationExamOfficeExamResultsChanged nExamResults jRecipient jSupervisor = do
+dispatchNotificationExamOfficeExamResultsChanged nExamResults jRecipient = do
   entitiesExamResults <- runDB $ selectList [ ExamResultId <-. Set.toList nExamResults ] []
   let exams = Set.fromList $ map (examResultExam . entityVal) entitiesExamResults
 
-  forM_ exams $ \nExam -> superMailT jSupervisor jRecipient $ do
+  forM_ exams $ \nExam -> userMailT jRecipient $ do
     (Course{..}, Exam{..}) <- liftHandler . runDB $ do
       exam <- getJust nExam
       course <- belongsToJust examCourse exam
@@ -66,8 +66,8 @@ dispatchNotificationExamOfficeExamResultsChanged nExamResults jRecipient jSuperv
     addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/examOffice/examResultsChanged.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
 
-dispatchNotificationExamOfficeExternalExamResults :: ExternalExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamOfficeExternalExamResults :: ExternalExamId -> UserId -> Handler ()
-dispatchNotificationExamOfficeExternalExamResults nExternalExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamOfficeExternalExamResults nExternalExam jRecipient = userMailT jRecipient $ do
   ExternalExam{..} <- liftHandler . runDB $ getJust nExternalExam
   replaceMailHeader "Auto-Submitted" $ Just "auto-generated"
   setSubjectI $ MsgMailSubjectExamOfficeExternalExamResults externalExamCourseName externalExamExamName

src/Jobs/Handler/SendNotification/ExamResult.hs

@@ -16,8 +16,8 @@ import Jobs.Handler.SendNotification.Utils
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationExamResult :: ExamId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationExamResult :: ExamId -> UserId -> Handler ()
-dispatchNotificationExamResult nExam jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationExamResult nExam jRecipient = userMailT jRecipient $ do
   (Course{..}, Exam{..}) <- liftHandler . runDB $ do
     exam <- getJust nExam
     course <- belongsToJust examCourse exam

src/Jobs/Handler/SendNotification/Qualification.hs

@@ -26,8 +26,8 @@ import qualified Data.CaseInsensitive as CI
 import Text.Hamlet
 
 
-dispatchNotificationQualificationExpiry :: QualificationId -> Day -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationQualificationExpiry :: QualificationId -> Day -> UserId -> Handler ()
-dispatchNotificationQualificationExpiry nQualification dExpiry jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationQualificationExpiry nQualification dExpiry jRecipient = userMailT jRecipient $ do
   (recipient@User{..}, Qualification{..}) <- liftHandler . runDB $ (,)
     <$> getJust jRecipient
     <*> getJust nQualification    
@@ -44,14 +44,11 @@ dispatchNotificationQualificationExpiry nQualification dExpiry jRecipient jSuper
 
   editNotifications <- mkEditNotifications jRecipient
 
-  -- if supervisor: 
+  addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/qualificationExpiry.hamlet")
-  let inner = $(ihamletFile "templates/mail/qualificationExpiry.hamlet")
-  --addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/supervisor.hamlet") -- uses ^{inner}
-  addHtmlMarkdownAlternatives inner
 
 
-dispatchNotificationQualificationExpired :: QualificationId -> Day -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationQualificationExpired :: QualificationId -> Day -> UserId -> Handler ()
-dispatchNotificationQualificationExpired nQualification dExpired jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationQualificationExpired nQualification dExpired jRecipient = userMailT jRecipient $ do
   (recipient@User{..}, Qualification{..}) <- liftHandler . runDB $ (,)
     <$> getJust jRecipient
     <*> getJust nQualification
@@ -72,8 +69,8 @@ dispatchNotificationQualificationExpired nQualification dExpired jRecipient jSup
 
 
 -- NOTE: qualificationRenewal expects that LmsUser already exists for recipient
-dispatchNotificationQualificationRenewal :: QualificationId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationQualificationRenewal :: QualificationId -> UserId -> Handler ()
-dispatchNotificationQualificationRenewal nQualification jRecipient jSupervisor = do
+dispatchNotificationQualificationRenewal nQualification jRecipient = do
   (recipient@User{..}, Qualification{..}, Entity _ QualificationUser{..}, Entity luid LmsUser{..}) <- runDB $ (,,,)
     <$> getJust jRecipient
     <*> getJust nQualification
@@ -114,7 +111,7 @@ dispatchNotificationQualificationRenewal nQualification jRecipient jSupervisor =
             $logErrorS "LMS" msg
             return False
         | otherwise = do
-            superMailT jSupervisor jRecipient $ do
+            userMailT jRecipient $ do
               replaceMailHeader "Auto-Submitted" $ Just "auto-generated"
               setSubjectI $ MsgMailSubjectQualificationRenewal qname
               whenIsJust attachment $ \afile ->

src/Jobs/Handler/SendNotification/SheetActive.hs

@@ -18,8 +18,8 @@ import Jobs.Handler.SendNotification.Utils
 import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationSheetActive, dispatchNotificationSheetHint, dispatchNotificationSheetSolution :: SheetId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSheetActive, dispatchNotificationSheetHint, dispatchNotificationSheetSolution :: SheetId -> UserId -> Handler ()
-dispatchNotificationSheetActive nSheet jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSheetActive nSheet jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}) <- liftHandler . runDB $ do
     sheet <- getJust nSheet
     course <- belongsToJust sheetCourse sheet
@@ -37,7 +37,7 @@ dispatchNotificationSheetActive nSheet jRecipient jSupervisor = superMailT jSupe
   editNotifications <- mkEditNotifications jRecipient
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/sheetActive.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
-dispatchNotificationSheetHint nSheet jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSheetHint nSheet jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}) <- liftHandler . runDB $ do
     sheet <- getJust nSheet
     course <- belongsToJust sheetCourse sheet
@@ -55,7 +55,7 @@ dispatchNotificationSheetHint nSheet jRecipient jSupervisor = superMailT jSuperv
   editNotifications <- mkEditNotifications jRecipient
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/sheetHint.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
-dispatchNotificationSheetSolution nSheet jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSheetSolution nSheet jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}) <- liftHandler . runDB $ do
     sheet <- getJust nSheet
     course <- belongsToJust sheetCourse sheet

src/Jobs/Handler/SendNotification/SheetInactive.hs

@@ -19,8 +19,8 @@ import qualified Data.CaseInsensitive as CI
 
 import qualified Database.Esqueleto.Legacy as E
 
-dispatchNotificationSheetSoonInactive :: SheetId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSheetSoonInactive :: SheetId -> UserId -> Handler ()
-dispatchNotificationSheetSoonInactive nSheet jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSheetSoonInactive nSheet jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}) <- liftHandler . runDB $ do
     sheet <- getJust nSheet
     course <- belongsToJust sheetCourse sheet
@@ -39,8 +39,8 @@ dispatchNotificationSheetSoonInactive nSheet jRecipient jSupervisor = superMailT
 
   addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/sheetSoonInactive.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
-dispatchNotificationSheetInactive :: SheetId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSheetInactive :: SheetId -> UserId -> Handler ()
-dispatchNotificationSheetInactive nSheet jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSheetInactive nSheet jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}, nrSubs, nrSubmitters, nrPseudonyms, nrParticipants) <- liftHandler . runDB $ do
     sheet <- getJust nSheet
     course <- belongsToJust sheetCourse sheet

src/Jobs/Handler/SendNotification/SubmissionEdited.hs

@@ -22,8 +22,8 @@ import qualified Database.Esqueleto.Legacy as E
 import qualified Data.Text as Text
 
 
-dispatchNotificationSubmissionEdited :: UserId -> SubmissionId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSubmissionEdited :: UserId -> SubmissionId -> UserId -> Handler ()
-dispatchNotificationSubmissionEdited nInitiator nSubmission jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSubmissionEdited nInitiator nSubmission jRecipient = userMailT jRecipient $ do
   (Course{..}, Sheet{..}, Submission{}, initiator, coSubmittors) <- liftHandler . runDB $ do
     submission <- getJust nSubmission
     sheet <- belongsToJust submissionSheet submission
@@ -57,8 +57,8 @@ dispatchNotificationSubmissionEdited nInitiator nSubmission jRecipient jSupervis
 
   addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/submissionEdited.hamlet")
 
-dispatchNotificationSubmissionUserCreated :: UserId -> SubmissionId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSubmissionUserCreated :: UserId -> SubmissionId -> UserId -> Handler ()
-dispatchNotificationSubmissionUserCreated nUser nSubmission jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSubmissionUserCreated nUser nSubmission jRecipient = userMailT jRecipient $ do
   (User{..}, Course{..}, Sheet{..}, Submission{}, coSubmittors) <- liftHandler . runDB $ do
     submission <- getJust nSubmission
     sheet <- belongsToJust submissionSheet submission
@@ -97,8 +97,8 @@ dispatchNotificationSubmissionUserCreated nUser nSubmission jRecipient jSupervis
   addHtmlMarkdownAlternatives $(ihamletFile "templates/mail/submissionUserCreated.hamlet")
 
 
-dispatchNotificationSubmissionUserDeleted :: UserId -> SheetId -> SubmissionId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSubmissionUserDeleted :: UserId -> SheetId -> SubmissionId -> UserId -> Handler ()
-dispatchNotificationSubmissionUserDeleted nUser nSheet nSubmission jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationSubmissionUserDeleted nUser nSheet nSubmission jRecipient = userMailT jRecipient $ do
   (User{..}, Course{..}, Sheet{..}, mSubmission, coSubmittors) <- liftHandler . runDB $ do
     submission <- get nSubmission
 

src/Jobs/Handler/SendNotification/SubmissionRated.hs

@@ -17,7 +17,7 @@ import Text.Hamlet
 import qualified Data.CaseInsensitive as CI
 
 
-dispatchNotificationSubmissionRated :: SubmissionId -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationSubmissionRated :: SubmissionId -> UserId -> Handler ()
 dispatchNotificationSubmissionRated nSubmission jRecipient = maybeT_ $ do
   (Course{..}, Sheet{..}, Submission{..}, corrector, sheetTypeDesc, hasAccess, csid) <- lift . runDB $ do
     submission@Submission{submissionRatingBy} <- getJust nSubmission

src/Jobs/Handler/SendNotification/UserAuthModeUpdate.hs

@@ -19,8 +19,8 @@ import Jobs.Handler.SendNotification.Utils
 import Text.Hamlet
 -- import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationUserAuthModeUpdate :: UserId -> AuthenticationMode -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationUserAuthModeUpdate :: UserId -> AuthenticationMode -> UserId -> Handler ()
-dispatchNotificationUserAuthModeUpdate  nUser _nOriginalAuthMode jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationUserAuthModeUpdate  nUser _nOriginalAuthMode jRecipient = userMailT jRecipient $ do
     User{..} <- liftHandler . runDB $ getJust nUser
     replaceMailHeader "Auto-Submitted" $ Just "auto-generated"
     setSubjectI MsgMailSubjectUserAuthModeUpdate

src/Jobs/Handler/SendNotification/UserRightsUpdate.hs

@@ -20,8 +20,8 @@ import qualified Data.Set as Set
 import Text.Hamlet
 -- import qualified Data.CaseInsensitive as CI
 
-dispatchNotificationUserRightsUpdate :: UserId -> Set (SchoolFunction, SchoolShorthand) -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationUserRightsUpdate :: UserId -> Set (SchoolFunction, SchoolShorthand) -> UserId -> Handler ()
-dispatchNotificationUserRightsUpdate  nUser _originalRights jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationUserRightsUpdate  nUser _originalRights jRecipient = userMailT jRecipient $ do
     (User{..}, functions)  <-  liftHandler . runDB $ do
       user <- getJust nUser
       functions <- Map.fromListWith Set.union . map (\(Entity _ UserFunction{..}) -> (userFunctionFunction, Set.singleton userFunctionSchool)) <$> selectList [UserFunctionUser ==. nUser] []
@@ -33,8 +33,8 @@ dispatchNotificationUserRightsUpdate  nUser _originalRights jRecipient jSupervis
     addHtmlMarkdownAlternatives ($(ihamletFile "templates/mail/userRightsUpdate.hamlet") :: HtmlUrlI18n (SomeMessage UniWorX) (Route UniWorX))
 
 
-dispatchNotificationUserSystemFunctionsUpdate :: UserId -> Set SystemFunction -> UserId -> Maybe UserId -> Handler ()
+dispatchNotificationUserSystemFunctionsUpdate :: UserId -> Set SystemFunction -> UserId -> Handler ()
-dispatchNotificationUserSystemFunctionsUpdate  nUser _originalSystemFunctions jRecipient jSupervisor = superMailT jSupervisor jRecipient $ do
+dispatchNotificationUserSystemFunctionsUpdate  nUser _originalSystemFunctions jRecipient = userMailT jRecipient $ do
     (User{..}, functions)  <-  liftHandler . runDB $ do
       user <- getJust nUser
       functions <- map (userSystemFunctionFunction . entityVal) <$> selectList [UserSystemFunctionUser ==. nUser] []