From 7bae03b4c056a8e99596307c4a9dce6558f36f13 Mon Sep 17 00:00:00 2001 From: Gregor Kleen Date: Wed, 17 Apr 2019 14:23:20 +0200 Subject: [PATCH] Use available constant in interactive fieldset utility --- static/js/utils/form.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/static/js/utils/form.js b/static/js/utils/form.js index 9c577725a..d4f97bb4a 100644 --- a/static/js/utils/form.js +++ b/static/js/utils/form.js @@ -3,6 +3,10 @@ var formUtilities = []; + var FORM_GROUP_SELECTOR = '.form-group'; + var FORM_GROUP_WITH_ERRORS_CLASS = 'form-group--has-error'; + + /** * * Reactive Submit Button Utility @@ -172,7 +176,7 @@ } conditionalValue = element.dataset.conditionalValue; - formGroup = element.closest('.form-group'); + formGroup = element.closest(FORM_GROUP_SELECTOR); if (!formGroup) { throw new Error('Interactive Fieldset needs a .form-group ancestor!'); } @@ -263,9 +267,6 @@ var FORM_ERROR_REMOVER_INITIALIZED_CLASS = 'form-error-remover--initialized'; var FORM_ERROR_REMOVER_INPUTS_SELECTOR = 'input:not([type="hidden"]), textarea, select'; - var FORM_GROUP_SELECTOR = '.form-group'; - var FORM_GROUP_WITH_ERRORS_CLASS = 'form-group--has-error'; - var formErrorRemoverUtil = function(element) { var formGroups;