Removed DisplayAble class

This commit is contained in:
Sarah Vaupel 2019-06-26 23:32:50 +02:00
parent f5b3dd4c3a
commit 726dbe6b1a
5 changed files with 2 additions and 25 deletions

View File

@ -45,8 +45,7 @@ makeSettingForm template html = do
<*> notificationForm (stgNotificationSettings <$> template)
return (result, widget) -- no validation required here
where
-- TODO: replace display
themeList = [Option (display t) t (toPathPiece t) | t <- universeF]
themeList = [Option (toMessage t) t (toPathPiece t) | t <- universeF]
--
-- Version with proper grouping:
--

View File

@ -45,8 +45,6 @@ seasonFromChar c
where
(~=) = (==) `on` CI.mk
-- instance DisplayAble Season
data TermIdentifier = TermIdentifier
{ year :: Integer -- ^ Using 'Integer' to model years is consistent with 'Data.Time.Calendar'
, season :: Season

View File

@ -39,6 +39,6 @@ instance Finite Theme
nullaryPathPiece ''Theme $ camelToPathPiece' 1
$(deriveSimpleWith ''DisplayAble 'display (over Text.packed $ Text.intercalate " " . unsafeTail . splitCamel) ''Theme) -- describe theme to user
$(deriveSimpleWith ''ToMessage 'toMessage (over Text.packed $ Text.intercalate " " . unsafeTail . splitCamel) ''Theme) -- describe theme to user
derivePersistField "Theme"

View File

@ -164,13 +164,6 @@ sheetFile2markup SheetHint = iconHint
sheetFile2markup SheetSolution = iconSolution
sheetFile2markup SheetMarking = iconMarking
-- $(deriveSimpleWith ''DisplayAble 'display (drop 17) ''SheetFileType)
-- instance DisplayAble SheetFileType where -- deprecated, see RenderMessage instance in Foundation
-- display SheetExercise = "Aufgabenstellung"
-- display SheetHint = "Hinweise"
-- display SheetSolution = "Musterlösung"
-- display SheetMarking = "Korrekturhinweise"
-- partitionFileType' :: Ord a => [(SheetFileType,a)] -> Map SheetFileType (Set a)
-- partitionFileType' = groupMap

View File

@ -231,22 +231,9 @@ str2widget :: (MonadBaseControl IO m, MonadThrow m, MonadIO m)
=> String -> WidgetT site m ()
str2widget s = [whamlet|#{s}|]
display2widget :: (MonadBaseControl IO m, MonadThrow m, MonadIO m, DisplayAble a)
=> a -> WidgetT site m ()
display2widget = text2widget . display
withFragment :: Monad m => MForm m (a, WidgetT site IO ()) -> Markup -> MForm m (a, WidgetT site IO ())
withFragment form html = flip fmap form $ over _2 (toWidget html >>)
-- Types that can be converted to Text for direct displayed to User! (Show for debugging, Display for Production)
{- (not so sure we really want to get rid of display?!) DEPRECATED display "Create RenderMessage Instances instead!" -}
class DisplayAble a where
display :: a -> Text
-- Default definitions for types belonging to Show (allows empty instance declarations)
default display :: Show a => a -> Text
display = pack . show
rationalToFixed3 :: Rational -> Fixed E3
rationalToFixed3 = fromRational