From 68fc4e4c3a373d83b4557b8ae33f86c496c6933b Mon Sep 17 00:00:00 2001
From: Sarah Vaupel <vaupel.sarah@campus.lmu.de>
Date: Tue, 26 Nov 2019 18:10:11 +0100
Subject: [PATCH] refactor(hide-columns): minor renaming and preparation for
 css work

---
 frontend/src/utils/hide-columns/hide-columns.js | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/frontend/src/utils/hide-columns/hide-columns.js b/frontend/src/utils/hide-columns/hide-columns.js
index 33bf474b0..6bc0bc8af 100644
--- a/frontend/src/utils/hide-columns/hide-columns.js
+++ b/frontend/src/utils/hide-columns/hide-columns.js
@@ -57,12 +57,12 @@ export class HideColumns {
   }
 
   setupHideButton(th, prevHidden) {
-    const hider = document.createElement('button');
+    const hider = document.createElement('span');
     hider.setAttribute(HIDER_TEXT_ATTR, th.innerText);
 
     hider.addEventListener('click', (event) => {
       event.preventDefault();
-      this.toggleColumnVisibility(th, hider);
+      this.switchColumnDisplay(th, hider);
     });
 
     // TODO fade in / fade out animation in css
@@ -81,23 +81,18 @@ export class HideColumns {
     this._tableUtilContainer.appendChild(hider);
   }
 
-  // TODO better name
-  toggleColumnVisibility(th, hider) {
+  switchColumnDisplay(th, hider) {
     const storageKey = this.getStorageKey(th);
 
     const hidden = !this._storageManager.load(storageKey);
 
-    // hide/unhide column
     this.updateColumnDisplay(th.cellIndex, hidden);
-
-    // tweak hider button
     this.updateHider(hider, hidden);
 
     // persist new hidden setting for column
     this._storageManager.save(storageKey, hidden);
   }
 
-  // TODO better name
   updateColumnDisplay(columnIndex, hidden) {
     this._element.getElementsByTagName('tr').forEach(row => {
       if (row.cells[columnIndex]) {
@@ -106,7 +101,6 @@ export class HideColumns {
     });
   }
 
-  // TODO better name
   updateHider(hider, hidden) {
     // TODO set css classes instead
     if (hidden) {