fix: tests & hlint

src/Handler/Utils/ExternalExam/Users.hs

@@ -191,7 +191,7 @@ makeExternalExamUsersTable mode (Entity eeId ExternalExam{..}) = do
 
         E.where_ $ result E.^. ExternalExamResultExam E.==. E.val eeId
 
-        unless (isLecturer || mode == EEUMUsers) $ do
+        unless (isLecturer || mode == EEUMUsers) $
           E.where_ $ ExternalExam.examOfficeExternalExamResultAuth (E.val uid) result
 
       return (result, user, isSynced)

src/Handler/Utils/Users.hs

@@ -50,7 +50,7 @@ guessUser (Set.toList -> criteria) = $cachedHereBinary criteria $ go False
             E.where_ . E.and $ map (toSql user) criteria 
             return user
       users <- retrieveUsers
-      let users' = reverse $ sortBy closeness users
+      let users' = sortBy (flip closeness) users
 
           matchesMatriculation :: Entity User -> Maybe Bool
           matchesMatriculation = preview $ _entityVal . _userMatrikelnummer . to (\userMatr -> all ((== userMatr) . Just) $ criteria ^.. folded . _guessUserMatrikelnummer)

test/FoundationSpec.hs

@@ -70,6 +70,10 @@ instance Arbitrary ExamOfficeR where
   arbitrary = genericArbitrary
   shrink = genericShrink
 
+instance Arbitrary EExamR where
+  arbitrary = genericArbitrary
+  shrink = genericShrink
+
 instance Arbitrary CourseNewsR where
   arbitrary = genericArbitrary
   shrink = genericShrink