refactor: hlint

src/Foundation.hs

@@ -1650,8 +1650,8 @@ wouldHaveReadAccessToIff, wouldHaveWriteAccessToIff
   => [(AuthTag, Bool)] -- ^ Assumptions
   -> Route UniWorX
   -> m Bool
-wouldHaveReadAccessToIff assumptions route = and2M (fmap not $ hasReadAccessTo route) $ wouldHaveReadAccessTo assumptions route
-wouldHaveWriteAccessToIff assumptions route = and2M (fmap not $ hasWriteAccessTo route) $ wouldHaveWriteAccessTo assumptions route
+wouldHaveReadAccessToIff assumptions route = and2M (not <$> hasReadAccessTo route) $ wouldHaveReadAccessTo assumptions route
+wouldHaveWriteAccessToIff assumptions route = and2M (not <$> hasWriteAccessTo route) $ wouldHaveWriteAccessTo assumptions route
 
 -- | Conditional redirect that hides the URL if the user is not authorized for the route
 redirectAccess :: (MonadThrow m, MonadHandler m, HandlerSite m ~ UniWorX) => Route UniWorX -> m a

src/Handler/Sheet/Edit.hs

@@ -86,7 +86,7 @@ handleSheetEdit tid ssh csh msId template dbAction = do
               , sheetAutoDistribute = sfAutoDistribute
               , sheetAnonymousCorrection = sfAnonymousCorrection
               , sheetRequireExamRegistration = sfRequireExamRegistration
-              , sheetAllowNonPersonalisedSubmission = fromMaybe True $ spffAllowNonPersonalisedSubmission <$> sfPersonalF
+              , sheetAllowNonPersonalisedSubmission = maybe True spffAllowNonPersonalisedSubmission sfPersonalF
               }
         mbsid <- dbAction newSheet
         case mbsid of
@@ -98,7 +98,7 @@ handleSheetEdit tid ssh csh msId template dbAction = do
             insertSheetFile' sid SheetMarking  $ fromMaybe (return ()) sfMarkingF
             runConduit $
                  maybe (return ()) (transPipe liftHandler) (spffFiles =<< sfPersonalF)
-              .| sinkPersonalisedSheetFiles cid sid (fromMaybe False $ spffFilesKeepExisting <$> sfPersonalF)
+              .| sinkPersonalisedSheetFiles cid sid (maybe False spffFilesKeepExisting sfPersonalF)
             insert_ $ SheetEdit aid actTime sid
             addMessageI Success $ MsgSheetEditOk tid ssh csh sfName
             -- Sanity checks generating warnings only, but not errors!