Minor cleanup

2018-12-05 12:05:18 +01:00 · 2018-12-05 12:05:18 +01:00 · 2a19b9368e
commit 2a19b9368e
parent 1d51280ebf
1 changed files with 9 additions and 17 deletions
--- a/src/Handler/Corrections.hs
+++ b/src/Handler/Corrections.hs
@ -708,23 +708,15 @@ postCorrectionsCreateR = do
                  when (null groups) $
                    addMessageI Warning $ MsgSheetNoRegisteredGroup sheetGroupDesc
              | otherwise -> addMessageI Error $ MsgSheetAmbiguousRegisteredGroup sheetGroupDesc
-          NoGroups
-            | [SheetPseudonym{sheetPseudonymUser}] <- spGroup
-              -> do
-                subId <- insert submissionPrototype
-                void . insert $ SubmissionEdit uid now subId
-                insert_ SubmissionUser
-                  { submissionUserUser = sheetPseudonymUser
-                  , submissionUserSubmission = subId
-                  }
-            | otherwise -> do
-                subId <- insert submissionPrototype
-                void . insert $ SubmissionEdit uid now subId
-                insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser
-                    { submissionUserUser = sheetPseudonymUser
-                    , submissionUserSubmission = subId
-                    }
-                addMessageI Warning $ MsgSheetNoGroupSubmission sheetGroupDesc
+          NoGroups -> do
+            subId <- insert submissionPrototype
+            void . insert $ SubmissionEdit uid now subId
+            insertMany_ . flip map spGroup $ \SheetPseudonym{sheetPseudonymUser} -> SubmissionUser
+              { submissionUserUser = sheetPseudonymUser
+              , submissionUserSubmission = subId
+              }
+            when (length spGroup > 1) $
+              addMessageI Warning $ MsgSheetNoGroupSubmission sheetGroupDesc
      redirect CorrectionsGradeR