From 1ce55982072de58d238d6679b27a3ee230ca468d Mon Sep 17 00:00:00 2001 From: Gregor Kleen Date: Tue, 17 Nov 2020 13:48:49 +0100 Subject: [PATCH] refactor: document cronNotAfter for exam closure --- src/Jobs/Crontab.hs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Jobs/Crontab.hs b/src/Jobs/Crontab.hs index 19411a3af..6320cb26d 100644 --- a/src/Jobs/Crontab.hs +++ b/src/Jobs/Crontab.hs @@ -365,6 +365,10 @@ determineCrontab = execWriterT $ do case closeTime of Just close -> do + -- If an exam that was previously under `ExamCloseSeparate` rules transitions to `ExamCloseOnFinish`, it might suddenly have been closed an arbitrary time ago + -- If `cronNotAfter` was only `appNotificationExpiration` in that case, no notification might ever be sent + -- That's probably fine. + changedResults <- lift . E.select . E.from $ \examResult -> do E.where_ $ examResult E.^. ExamResultExam E.==. E.val nExam E.&&. examResult E.^. ExamResultLastChanged E.>. E.val close