From 086e49e2ae126f6acb9be774b0351d37443c31d8 Mon Sep 17 00:00:00 2001 From: Steffen Jost Date: Wed, 1 Feb 2023 13:20:51 +0100 Subject: [PATCH] fix(sap): do not export e-accounts --- src/Handler/SAP.hs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Handler/SAP.hs b/src/Handler/SAP.hs index cf83e6c22..4e8b98ebc 100644 --- a/src/Handler/SAP.hs +++ b/src/Handler/SAP.hs @@ -53,10 +53,11 @@ instance ToNamedRecord SapUserTableCsv where , "Ausprägung" Csv..= csvSUTausprägung ] --- | Removes all elements containing Nothing, which should not be returend by the query anyway (only qualfications with sap id and users with internal personnel number must be transmitted) +-- | Removes all personalNummer which are not numbers (i.e. excludes E-Accounts), which should not be returned by the query anyway (only qualfications with sap id and users with internal personnel number must be transmitted) -- TODO: once temporary suspensions are implemented, a user must be transmitted to SAP in two rows: firstheld->suspensionFrom & suspensionTo->validTo sapRes2csv :: [(Ex.Value (Maybe Text), Ex.Value Day, Ex.Value Day, Ex.Value (Maybe Text))] -> [SapUserTableCsv] sapRes2csv l = [ res | (Ex.Value (Just persNo), Ex.Value firstHeld, Ex.Value validUntil, Ex.Value (Just sapId)) <- l + , readMay persNo > Just 0 -- filter E-accounts for SAP export , let res = SapUserTableCsv { csvSUTpersonalNummer = persNo , csvSUTqualifikation = sapId @@ -101,4 +102,4 @@ getQualificationSAPDirectR = do csvRenderedToTypedContentWith csvOpts csvSheetName csvRendered -- direct Download see: --- https://ersocon.net/blog/2017/2/22/creating-csv-files-in-yesod \ No newline at end of file +-- https://ersocon.net/blog/2017/2/22/creating-csv-files-in-yesod