fraport/fradrive-old
fraport/fradrive-old
Archived
3
1
Fork 0
Code Issues 65 Pull Requests 5 Actions Packages Projects Releases 197 Wiki Activity

fix(schedule): return FormFailure

Browse Source
This commit is contained in:
Sarah Vaupel 2020-09-03 20:49:35 +02:00
parent 9fb4aa1429
commit 2d921ba20b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Handler/Schedule.hs
View File

@ -15,6 +15,7 @@ getScheduleR = postScheduleR
postScheduleR = do postScheduleR = do
uid <- requireAuthId uid <- requireAuthId
-- TODO: local instead of global get params?
mView <- lookupGlobalGetParam GetScheduleView mView <- lookupGlobalGetParam GetScheduleView
mOffset <- lookupGlobalGetParam GetScheduleOffset mOffset <- lookupGlobalGetParam GetScheduleOffset
@ -48,7 +49,7 @@ postScheduleR = do
| Just errs <- fromNullable (filter (is _FormFailure) viewRess) -> do | Just errs <- fromNullable (filter (is _FormFailure) viewRess) -> do
mapM_ formFailure2Alerts errs mapM_ formFailure2Alerts errs
$logInfoS "SCHEDULE-VIEW" $ "encountered error(s): " <> tshow errs $logInfoS "SCHEDULE-VIEW" $ "encountered error(s): " <> tshow errs
return FormMissing -- TODO: return FormFailure (return . FormFailure . mconcat . catMaybes . (fmap $ preview _FormFailure) . toNullable) errs
| otherwise -> case catMaybes (formResultToMaybe <$> viewRess) of -- TODO: rethink this case | otherwise -> case catMaybes (formResultToMaybe <$> viewRess) of -- TODO: rethink this case
[sView] -> do [sView] -> do
$logInfoS "SCHEDULE-VIEW" $ "encountered single view result: " <> tshow sView <> ", all results: " <> tshow viewRess $logInfoS "SCHEDULE-VIEW" $ "encountered single view result: " <> tshow sView <> ", all results: " <> tshow viewRess
@ -71,7 +72,7 @@ postScheduleR = do
| Just errs <- fromNullable (filter (is _FormFailure) offsetRess) -> do | Just errs <- fromNullable (filter (is _FormFailure) offsetRess) -> do
mapM_ formFailure2Alerts errs mapM_ formFailure2Alerts errs
$logInfoS "SCHEDULE-OFFSET" $ "encountered error(s): " <> tshow errs $logInfoS "SCHEDULE-OFFSET" $ "encountered error(s): " <> tshow errs
return FormMissing -- TODO: return FormFailure (return . FormFailure . mconcat . catMaybes . (fmap $ preview _FormFailure) . toNullable) errs
| otherwise -> case catMaybes (formResultToMaybe <$> offsetRess) of -- TODO: rethink this case | otherwise -> case catMaybes (formResultToMaybe <$> offsetRess) of -- TODO: rethink this case
[offset] -> do [offset] -> do
$logInfoS "SCHEDULE-OFFSET" $ "encountered single offset result: " <> tshow offset <> ", all results: " <> tshow offsetRess $logInfoS "SCHEDULE-OFFSET" $ "encountered single offset result: " <> tshow offset <> ", all results: " <> tshow offsetRess