fix: smaller fixes and typos

This commit is contained in:
Johannes Eder 2021-07-21 12:30:23 +02:00 committed by Sarah Vaupel
parent 1a8fb23044
commit 1f978e65a8
3 changed files with 7 additions and 5 deletions

View File

@ -41,7 +41,7 @@ export class CheckAll {
if (DEBUG_MODE > 0)
console.log(this._columns);
this._findCheckboxColumns().forEach(columnId => this._checkAllColumns.push(new CheckAllColumn(this._element, app, this._columns[columnId])));
this._findCheckboxColumns().forEach(columnId => this._checkAllColumns.push(new CheckAllColumn(this._element, app, this._columns[columnId], this._eventManager)));
// mark initialized
this._element.classList.add(CHECK_ALL_INITIALIZED_CLASS);
@ -50,7 +50,8 @@ export class CheckAll {
destroy() {
this._eventManager.removeAllEventListenersFromUtil();
this._checkAllColumns.forEach((column) => {
column._checkAllCheckBox.remove();
if (column._checkAllCheckBox !== undefined)
column._checkAllCheckBox.remove();
});
if(this._element.classList.contains(CHECK_ALL_INITIALIZED_CLASS))

View File

@ -55,7 +55,8 @@ export class Checkbox {
}
destroy() {
this._wrapperEl.remove();
if (this._wrapperEl !== undefined)
this._wrapperEl.remove();
this._element.classList.remove(CHECKBOX_INITIALIZED_CLASS);
}
}

View File

@ -49,7 +49,7 @@ export class Password {
start() {
this.updateVisibleIcon(this.isVisible());
const mouseOverEv = new EventWrapper(EVENT_TYPE.MOUS_OVER, (() => {
const mouseOverEv = new EventWrapper(EVENT_TYPE.MOUSE_OVER, (() => {
this.updateVisibleIcon(!this.isVisible());
}).bind(this), this._toggleContainerEl);
@ -57,7 +57,7 @@ export class Password {
this.updateVisibleIcon(this.isVisible());
}).bind(this), this._toggleContainerEl);
const clickEv = new EventWrapper(EVENT_TYPE.CLICK,((event) => {
const clickEv = new EventWrapper(EVENT_TYPE.CLICK, ((event) => {
event.preventDefault();
event.stopPropagation();
this.setVisible(!this.isVisible());