From 0823df33b5f157af290aca9a65f1df429048e53b Mon Sep 17 00:00:00 2001
From: Johannes Eder <ederj@cip.ifi.lmu.de>
Date: Tue, 3 Aug 2021 17:34:28 +0200
Subject: [PATCH] feat(http-client): added possibility to remove specific
 interceptors

---
 frontend/src/services/http-client/http-client.js     | 12 ++++++++++++
 .../src/services/http-client/http-client.spec.js     | 10 +++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/frontend/src/services/http-client/http-client.js b/frontend/src/services/http-client/http-client.js
index 274f86cdb..28d7cba21 100644
--- a/frontend/src/services/http-client/http-client.js
+++ b/frontend/src/services/http-client/http-client.js
@@ -15,6 +15,18 @@ export class HttpClient {
     }
   }
 
+  removeResponseInterceptor(interceptor) {
+    //performs a reference check. if the interceptor is bound, when adding it, the reference of the bound function needs to be the same when removing it later.
+
+    if (typeof interceptor !== 'function') {
+      throw new Error(`Cannot remove Interceptor ${interceptor}, because it is not of type function`);
+    }
+    if(this._responseInterceptors.filter(el => el == interceptor).length !== 1) {
+      throw new Error(`Could not find Response Interceptor ${interceptor}.`);
+    }
+    this._responseInterceptors = this._responseInterceptors.filter(el => el != interceptor);
+  }
+
   _baseUrl;
 
   setBaseUrl(baseUrl) {
diff --git a/frontend/src/services/http-client/http-client.spec.js b/frontend/src/services/http-client/http-client.spec.js
index a0f76584d..594f7096c 100644
--- a/frontend/src/services/http-client/http-client.spec.js
+++ b/frontend/src/services/http-client/http-client.spec.js
@@ -75,7 +75,7 @@ describe('HttpClient', () => {
       expect(httpClient._responseInterceptors.length).toBe(2);
     });
 
-    describe('get called', () => {
+    describe('get called and removed', () => {
       let intercepted1;
       let intercepted2;
       const interceptors = {
@@ -111,6 +111,14 @@ describe('HttpClient', () => {
           done();
         });
       });
+
+      it('can be removed', () => {
+        expect(httpClient._responseInterceptors.length).toBe(2);
+        httpClient.removeResponseInterceptor(interceptors.interceptor1);
+        expect(httpClient._responseInterceptors.length).toBe(1);
+        expect(() => {httpClient.removeResponseInterceptor(interceptors.interceptor1);}).toThrow();
+        expect(httpClient._responseInterceptors.length).toBe(1);
+      });
     });
   });
 });